Generate kfactors for polarized observables by toonhasenack · Pull Request #132 · NNPDF/pineko

toonhasenack · 2023-10-23T08:50:41Z

Initial pull request for generating the K-factors of the F1 structure functions for polarized DIS data.

giacomomagni · 2023-10-23T08:52:29Z

This PR is mostly to keep track of @toonhasenack work, we might no merge this in the end.

felixhekhorn · 2023-10-23T09:47:41Z

+import argparse
+
+
+def get_gpaths(folder):


Consider adding type hints

@toonhasenack when using type hints you can actually drop the repeated argument type in the doc string - see e.g. the second example here

felixhekhorn · 2023-10-23T09:48:41Z

+        strf_data += f"{data[i]}  0.0\n"
+
+    date = dt.now().date()
+    string = (


Make this a module constant

felixhekhorn · 2023-10-23T09:49:35Z

+        + strf_data
+    )
+
+    os.makedirs(output_name, exist_ok=True)


Maybe prefer pathlib over os

felixhekhorn · 2023-10-23T09:51:25Z

This PR is mostly to keep track of @toonhasenack work, we might no merge this in the end.

Maybe this is not a priority, but I think we do want to merge because this strategy will persists also in the mid-term

toonhasenack · 2023-10-23T11:05:23Z

See latest push for adjustments

alecandido · 2023-11-22T09:27:24Z

Maybe this is not a priority, but I think we do want to merge because this strategy will persists also in the mid-term

Are you sure that this should belong to Pineko? It is quite DIS specific... (even more, just specific to some observable)

felixhekhorn · 2024-03-13T11:22:07Z

Maybe this is not a priority, but I think we do want to merge because this strategy will persists also in the mid-term

Are you sure that this should belong to Pineko? It is quite DIS specific... (even more, just specific to some observable)

I think it is fine to have it here, pineko has the k-factor option - of course the other option is to push it back to yadism

felixhekhorn · 2024-03-13T11:23:14Z

@toonhasenack please remember the comments from above and also try to unify the scripts as much as you can, they are all similar to each other

PS: as always: please also fix pre-commit

alecandido · 2024-03-13T12:09:45Z

I think it is fine to have it here, pineko has the k-factor option - of course the other option is to push it back to yadism

Pineko is applying k-factors, but not computing them. We always kept Pineko process agnostic, and I believe that's a good thing (since all the complexity of the processes is delegated to the respective generators, and we avoid coupling to a specific one - in particular DIS, as in APFEL).

felixhekhorn · 2024-03-14T14:08:30Z

I think it is fine to have it here, pineko has the k-factor option - of course the other option is to push it back to yadism

Pineko is applying k-factors, but not computing them. We always kept Pineko process agnostic, and I believe that's a good thing (since all the complexity of the processes is delegated to the respective generators, and we avoid coupling to a specific one - in particular DIS, as in APFEL).

okay, I agree - so @toonhasenack

please move the scripts to yadism/extras
keep the fixes for SV and add (at least) timelike (cc @t7phy ) and please do a proper iteration - actually, why don't we transfer all keys @andreab1997 ?

giacomomagni · 2024-03-14T14:09:57Z

keep the fixes for SV and add (at least) timelike (cc @t7phy ) and please do a proper iteration - actually, why don't we transfer all keys @andreab1997 ?

Yes indeed that would be the proper fix. I can take care of it, here.

andreab1997 · 2024-03-14T14:23:14Z

I think it is fine to have it here, pineko has the k-factor option - of course the other option is to push it back to yadism

Pineko is applying k-factors, but not computing them. We always kept Pineko process agnostic, and I believe that's a good thing (since all the complexity of the processes is delegated to the respective generators, and we avoid coupling to a specific one - in particular DIS, as in APFEL).

okay, I agree - so @toonhasenack

please move the scripts to yadism/extras

keep the fixes for SV and add (at least) timelike (cc @t7phy ) and please do a proper iteration - actually, why don't we transfer all keys @andreab1997 ?

What do you mean with all keys?

felixhekhorn · 2024-03-14T14:43:40Z

What do you mean with all keys?

all metadata present in original grid like result, generator info, etc. (pinefarm can add an arbitrary amount of metadata, which is also unpredictable) - I think @giacomomagni understood ... in practice only a for k,v in ori.key_values() is needed

felixhekhorn · 2024-03-15T13:35:50Z

What do you mean with all keys?

all metadata present in original grid like result, generator info, etc. (pinefarm can add an arbitrary amount of metadata, which is also unpredictable) - I think @giacomomagni understood ... in practice only a for k,v in ori.key_values() is needed

this is done in #161 - so please just close @toonhasenack when you have moved the scripts

felixhekhorn · 2024-03-19T12:21:20Z

@toonhasenack please don't push here. Close this one an reopen in yadism.

Radonirinaunimi · 2024-03-21T09:28:18Z

+    for i, bin in enumerate(bins):
+        prediction[i] = (
+            bin["y"]["mid"]
+            * (2 - bin["y"]["mid"])
+            / (bin["y"]["mid"] ** 2 + 2 * (1 - bin["y"]["mid"]))
+        )


@toonhasenack Here we are missing the $1/(2xF_1)$ factor.

felixhekhorn · 2024-03-22T14:51:24Z

moved to NNPDF/yadism#270

toonhasenack added 2 commits October 18, 2023 14:23

Initial F1 generator ready.

ef015b2

Adjustment for compatibility of output with Pineko

7e2d356

giacomomagni added the enhancement New feature or request label Oct 23, 2023

giacomomagni assigned toonhasenack Oct 23, 2023

giacomomagni marked this pull request as draft October 23, 2023 08:52

giacomomagni removed the enhancement New feature or request label Oct 23, 2023

giacomomagni reviewed Oct 23, 2023

View reviewed changes

Comment thread data/kfactors/generate.py Outdated

giacomomagni reviewed Oct 23, 2023

View reviewed changes

Comment thread data/kfactors/generate.py Outdated

felixhekhorn changed the title ~~Generate kfactors~~ Generate kfactors for F1 division Oct 23, 2023

felixhekhorn added the enhancement New feature or request label Oct 23, 2023

felixhekhorn reviewed Oct 23, 2023

View reviewed changes

Adjusted docstring, arg types and some minor stuff

044e1a4

Added the g1 and corrected proton/neutron case

0d43d7b

toonhasenack added 5 commits December 11, 2023 14:57

g1f1 polarized flag fix and kfactors

359b37d

Merge branch 'main' into generate_kfactors

91c3a1a

automation good

fa75aeb

theory key for g1f1

e62dbbe

initial push for ALL normalization

2c8d260

g1f1 correctly adopted for nFONLL

57b3b5e

Radonirinaunimi reviewed Mar 21, 2024

View reviewed changes

Radonirinaunimi changed the title ~~Generate kfactors for F1 division~~ Generate kfactors for polarized observables Mar 21, 2024

1/2xF1 for ALL too

a18ff15

felixhekhorn mentioned this pull request Mar 22, 2024

Generate kfactors for polarized observables NNPDF/yadism#270

Closed

felixhekhorn closed this Mar 22, 2024

felixhekhorn deleted the generate_kfactors branch March 22, 2024 14:51

		import argparse


		def get_gpaths(folder):

Conversation

toonhasenack commented Oct 23, 2023

Uh oh!

giacomomagni commented Oct 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixhekhorn Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

felixhekhorn Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

felixhekhorn commented Oct 23, 2023

Uh oh!

toonhasenack commented Oct 23, 2023

Uh oh!

alecandido commented Nov 22, 2023

Uh oh!

felixhekhorn commented Mar 13, 2024

Uh oh!

felixhekhorn commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alecandido commented Mar 13, 2024

Uh oh!

felixhekhorn commented Mar 14, 2024

Uh oh!

giacomomagni commented Mar 14, 2024

Uh oh!

andreab1997 commented Mar 14, 2024

Uh oh!

felixhekhorn commented Mar 14, 2024

Uh oh!

felixhekhorn commented Mar 15, 2024

Uh oh!

felixhekhorn commented Mar 19, 2024

Uh oh!

Radonirinaunimi Mar 21, 2024

Choose a reason for hiding this comment

Uh oh!

felixhekhorn commented Mar 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

felixhekhorn commented Mar 13, 2024 •

edited

Loading