Change max_as during FONLL-B DIS fk calculation#27
Conversation
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 40.00% 40.75% +0.75%
==========================================
Files 15 15
Lines 520 530 +10
==========================================
+ Hits 208 216 +8
- Misses 312 314 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
same here: should I add tests here? |
I'm not connecting to what "same" is referred, but definitely yes. Add as many relevant tests as you can! |
yes sorry, I forgot to tag the other PR. Same of #24 |
|
again, I am asking the review only for the test |
look for a generic lepton Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
|
For me now would be even fine, but tests are failing, I guess because I forgot a if not (10 < abs(el[1]) < 17): |
|
If tests will pass, you can merge @andreab1997 |
Yes of course |
We need pineko to change the
max_asvalue from 1 to 2 when computing FONLL-B DIS fktables.Solves #26