[do not merge] Debug SV scheme B

[felixhekhorn]

I will keep investigating here - if ever I find something, I'll either create a new PR or convert this one ...

[felixhekhorn]

@alecandido stupid question: how can I force github to update "Files changes"? because git diff does show the correct thing (i.e. the 3 debug files as difference)

[alecandido]

Your commit appears to have a single file changed:

557a5fb

even locally:

debug.py

──────────────────────────────────────┐
12: hpdf = apply.apply_pdf(ho, gonly) │
──────────────────────────────────────┘
│ 12 │bo = eko.output.Output.load_tar("data/ekos/2201/test.tar")                                                  │ 12 │bo = eko.output.Output.load_tar("data/ekos/2201/test.tar")
│ 13 │bpdf = apply.apply_pdf(bo, gonly)                                                                           │ 13 │bpdf = apply.apply_pdf(bo, gonly)
│ 14 │                                                                                                            │ 14 │
│    │                                                                                                            │ 15 │# a is the output of the sv script                                                                         
│ 15 │plot(np.log(a[:, 2]), a[:, 4])                                                                              │ 16 │plot(np.log(a[:, 2]), a[:, 4])
│ 16 │plot(np.log(a[:, 2]), a[:, 6])                                                                              │ 17 │plot(np.log(a[:, 2]), a[:, 6])
│ 17 │plot(np.log(a[:, 2]), 4 * 5 / 9 * a[:, 2] * bpdf[300.0]["pdfs"][2])                                         │ 18 │plot(np.log(a[:, 2]), 4 * 5 / 9 * a[:, 2] * bpdf[300.0]["pdfs"][2])

[felixhekhorn]

that's correct - I needed a new commit to branch again; the thing is that the reference branch (feature/sv) changed meanwhile

[alecandido]

Rebase the branch.

I believe "File Changed" are only showing the changes made in this PR (i.e. in this branch), so wrt the commit you branched off.
If you rebase, it will be wrt the new commit :)

Otherwise if you to keep going with the outdated branch, just keep doing git diff (GitHub is exposing both the information types: "Files Changed" -> what you did in this PR, "Conflicting files" -> you are not up do the date, and there are files affected by both).

Simply "Files Changed" != git diff.

[codecov]

Codecov Report

Merging #29 (deaf045) into main (6568293) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   44.03%   44.03%           
=======================================
  Files          16       16           
  Lines         604      604           
=======================================
  Hits          266      266           
  Misses        338      338           

Flag	Coverage Δ
unittests	44.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[codecov-commenter]

Codecov Report

Merging #29 (99f6c78) into main (67ae7c3) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          17       17           
  Lines         633      633           
=======================================
  Hits          559      559           
  Misses         74       74           

Flag	Coverage Δ
bench	87.04% <0.00%> (ø)
unittests	46.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pineko/theory.py	84.88% <0.00%> (ø)

[andreab1997]

Do we want to close this? @felixhekhorn

[felixhekhorn]

Agreed