Refactor sub scvar

[andreab1997]

No description provided.

[codecov-commenter]

Codecov Report

Merging #48 (a5358a1) into main (d67e52c) will increase coverage by 0.59%.
The diff coverage is 90.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   88.35%   88.94%   +0.59%     
==========================================
  Files          16       16              
  Lines         601      606       +5     
==========================================
+ Hits          531      539       +8     
+ Misses         70       67       -3     

Flag	Coverage Δ
bench	87.41% <90.90%> (+0.60%)	⬆️
unittests	47.35% <18.18%> (+0.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pineko/cli/check.py	96.07% <90.90%> (+6.94%)	⬆️

[alecandido]

I would propose to use enum for them, something like:

from enum import Enum, auto

class Scale(Enum):
    REN = auto()
    FACT = auto()

@click.argument(
    "scale",
    metavar="SCALE",
    type=click.Choice(list(map(lambda x: x.name.lower(), Scale)), case_sensitive=False),
)
...

It is more explicit, and may give more introspection in debugging.

[andreab1997]

I would propose to use enum for them, something like:

from enum import Enum, auto

class Scale(Enum):
    REN = auto()
    FACT = auto()

@click.argument(
    "scale",
    metavar="SCALE",
    type=click.Choice(list(map(lambda x: x.name.lower(), Scale)), case_sensitive=False),
)
...

It is more explicit, and may give more introspection in debugging.

Do you mean something similar to what I have done in the last commit?

[alecandido]

Do you mean something similar to what I have done in the last commit?

Similar yes, but we can still improve: I added a bunch of comments.

I trust that is working, but since our code is growing, I'm trying to focus on improving the quality, to make it more maintainable (just because we're scaling, and trying to stabilize our infrastructure).

[andreab1997]

Ok thank you @alecandido for the suggestions, this should be fine now

[andreab1997]

I think we can merge. Thanks for this!