Skip to content

Import content from N3PDF/external#4

Merged
alecandido merged 2 commits into
mainfrom
import-external
Oct 20, 2022
Merged

Import content from N3PDF/external#4
alecandido merged 2 commits into
mainfrom
import-external

Conversation

@alecandido
Copy link
Copy Markdown
Collaborator

@alecandido alecandido changed the base branch from main to lhapdf-container October 4, 2022 15:17
@felixhekhorn
Copy link
Copy Markdown
Collaborator

let's not port backup stuff ...

Base automatically changed from lhapdf-container to main October 4, 2022 15:34
@alecandido
Copy link
Copy Markdown
Collaborator Author

alecandido commented Oct 4, 2022

let's not port backup stuff ...

Unfortunately, without that FONLLdis is not working out of the box. If you wish you can find another solution (maybe it is really simple, but I have no time at the moment).

The moment we have a solution, we can also remove from history, and keep the repo free of that junk, however:

drwxrwxr-x    - alessandro  4 ott 17:04 packages/.backup
.rw-rw-r-- 1,9M alessandro  4 ott 17:04 ├── FONLLdis.tar.gz
.rw-rw-r--  316 alessandro  4 ott 17:04 ├── update.sh
.rw-rw-r--  17k alessandro  4 ott 17:04 └── xspace-bench.tar.gz

So, for xspace-bench is really negligible, and FONLLdis has the size of a picture, and not going to increase. Everything else I removed, as you can see.
For me would be much nicer (since cleaner) to remove it, but it's definitely not worth my effort, given limited resources.

P.S.: all the weight in FONLLdis.tar.gz seems to come from the toy grids, that are shipped also separately... there is definitely some duplication

@felixhekhorn
Copy link
Copy Markdown
Collaborator

I perfectly agree - I wasn't aware it is actually used ... keep it (maybe rename it?)

@alecandido
Copy link
Copy Markdown
Collaborator Author

Do what you prefer. I don't really have a better name :)

@felixhekhorn
Copy link
Copy Markdown
Collaborator

legacy? (without any leading .)

@alecandido
Copy link
Copy Markdown
Collaborator Author

legacy? (without any leading .)

Not really, there is nothing legacy: that is the actual FONLLdis, and not going to change...

@felixhekhorn
Copy link
Copy Markdown
Collaborator

local_codes?

@alecandido
Copy link
Copy Markdown
Collaborator Author

Still prefer .backup. It is a back-up of the code...

@felixhekhorn
Copy link
Copy Markdown
Collaborator

Still prefer .backup. It is a back-up of the code...

They are not. That's what me confused in the first place - they are the one and only source of truth. external? Or at least remove the leading . or else I give up

@alecandido
Copy link
Copy Markdown
Collaborator Author

alecandido commented Oct 5, 2022

they are the one and only source of truth

Nope, it's a dirty trick. The source of truth is NNPDF/external.

And I would use that one, but it is a private repo, and it might cause issues in many situations. That's why I needed a .backup.
(and I like the . because it is a dirty trick, and I want to keep hidden as much as possible, such that no one will abuse of it)

Just to explain: it is a dirty trick because I decided not to host the code, as a general principle, in order not to duplicate and have to maintain the copy (as it was before). Here I'm giving up, because practicality beats purity.

@alecandido alecandido merged commit fb7177a into main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants