Skip to content

Added dataset permissions#100

Merged
einfachMel merged 2 commits intomainfrom
feature/permissions
Feb 17, 2022
Merged

Added dataset permissions#100
einfachMel merged 2 commits intomainfrom
feature/permissions

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Feb 10, 2022

Fixes #17

This PR ...

adds permissions to datasets.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-100-Preview February 10, 2022 09:19 Destroyed
@V3lop5 V3lop5 requested a review from einfachMel February 10, 2022 09:48
@V3lop5 V3lop5 added the enhancement New feature or request label Feb 10, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #100 (9dc0fe3) into main (e0f6749) will decrease coverage by 1.91%.
The diff coverage is 60.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   79.46%   77.55%   -1.92%     
==========================================
  Files          98      103       +5     
  Lines        2031     2223     +192     
==========================================
+ Hits         1614     1724     +110     
- Misses        417      499      +82     
Flag Coverage Δ
pytest 77.55% <60.76%> (-1.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/api/endpoints/energy_models.py 52.63% <22.22%> (-6.56%) ⬇️
ensysmod/api/endpoints/energy_commodities.py 63.15% <28.57%> (-8.72%) ⬇️
ensysmod/api/endpoints/regions.py 63.15% <28.57%> (-8.72%) ⬇️
ensysmod/api/endpoints/datasets_permissions.py 29.09% <29.09%> (ø)
ensysmod/api/endpoints/ts_capacity_fix.py 62.50% <50.00%> (-1.95%) ⬇️
ensysmod/api/endpoints/ts_capacity_max.py 62.50% <50.00%> (-1.95%) ⬇️
ensysmod/api/endpoints/ts_operation_rate_fix.py 62.50% <50.00%> (-1.95%) ⬇️
ensysmod/api/endpoints/ts_operation_rate_max.py 62.50% <50.00%> (-1.95%) ⬇️
ensysmod/crud/dataset_permission.py 58.33% <58.33%> (ø)
ensysmod/api/permissions.py 80.00% <80.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f6749...9dc0fe3. Read the comment docs.

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   41s ⏱️ +5s
63 tests ±0  63 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9dc0fe3. ± Comparison against base commit e0f6749.

@github-actions github-actions bot temporarily deployed to PR-100-Preview February 10, 2022 09:53 Destroyed
@einfachMel einfachMel merged commit f7af89a into main Feb 17, 2022
@einfachMel einfachMel deleted the feature/permissions branch February 17, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add permissions for datasets

3 participants