Skip to content

Feature/pydantic validators#101

Merged
V3lop5 merged 17 commits intomainfrom
feature/pydantic-validators
Feb 16, 2022
Merged

Feature/pydantic validators#101
V3lop5 merged 17 commits intomainfrom
feature/pydantic-validators

Conversation

@einfachMel
Copy link
Copy Markdown
Collaborator

@einfachMel einfachMel commented Feb 10, 2022

Fixes #60

This PR ...

validates all possible input for correct content


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@V3lop5 V3lop5 self-requested a review February 10, 2022 09:49
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

    1 files  ±    0      1 suites  ±0   48s ⏱️ +12s
400 tests +337  384 ✔️ +321  16 💤 +16  0 ±0 

Results for commit af2aaff. ± Comparison against base commit e0f6749.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #101 (af2aaff) into main (e0f6749) will increase coverage by 1.77%.
The diff coverage is 93.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   79.46%   81.24%   +1.77%     
==========================================
  Files          98       99       +1     
  Lines        2031     2330     +299     
==========================================
+ Hits         1614     1893     +279     
- Misses        417      437      +20     
Flag Coverage Δ
pytest 81.24% <93.73%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/util/validators.py 90.78% <90.78%> (ø)
ensysmod/schemas/__init__.py 100.00% <100.00%> (ø)
ensysmod/schemas/dataset.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_commodity.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_component.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_conversion.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_conversion_factor.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_model.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_sink.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_source.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f6749...af2aaff. Read the comment docs.

@github-actions github-actions bot temporarily deployed to PR-101-Preview February 10, 2022 09:55 Destroyed
@V3lop5 V3lop5 added the enhancement New feature or request label Feb 16, 2022
@V3lop5 V3lop5 merged commit 9d7f79d into main Feb 16, 2022
@V3lop5 V3lop5 deleted the feature/pydantic-validators branch February 16, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add value validators and tests

3 participants