Skip to content

Add models for dataset and energy-model#18

Merged
einfachMel merged 27 commits intomainfrom
feature/rework-models
Dec 9, 2021
Merged

Add models for dataset and energy-model#18
einfachMel merged 27 commits intomainfrom
feature/rework-models

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Dec 5, 2021

Fixes #16

This PR ...


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successfull
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

Reworked models
Added schemas
Added crud operations
Added endpoints
Added default user for tests
Added tests for endpoints
Added prefix ts_ for all time series related models
@V3lop5 V3lop5 changed the title Feature/rework models Add models for dataset and energy-model Dec 5, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 5, 2021

Codecov Report

Merging #18 (46139b1) into main (7aa982b) will increase coverage by 1.81%.
The diff coverage is 88.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   88.55%   90.37%   +1.81%     
==========================================
  Files          46       72      +26     
  Lines         568     1153     +585     
==========================================
+ Hits          503     1042     +539     
- Misses         65      111      +46     
Flag Coverage Δ
pytest 90.37% <88.66%> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/api/endpoints/ts_capacity_max.py 63.82% <63.82%> (ø)
ensysmod/api/endpoints/ts_operation_rate_fix.py 63.82% <63.82%> (ø)
ensysmod/api/endpoints/ts_operation_rate_max.py 63.82% <63.82%> (ø)
ensysmod/api/endpoints/energy_commodities.py 71.87% <71.87%> (ø)
ensysmod/api/endpoints/regions.py 71.87% <71.87%> (ø)
ensysmod/app.py 92.85% <80.00%> (-7.15%) ⬇️
ensysmod/crud/region.py 90.90% <80.00%> (+2.02%) ⬆️
ensysmod/crud/energy_sink.py 88.00% <83.33%> (-0.89%) ⬇️
ensysmod/crud/energy_source.py 88.00% <83.33%> (-0.89%) ⬇️
ensysmod/crud/user.py 95.00% <83.33%> (-5.00%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa982b...46139b1. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 5, 2021 17:28 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 5, 2021 21:15 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 5, 2021 21:35 Destroyed
Added time series capacity max
Added time series operation rate max
Added time series operation rate fix
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 8, 2021 21:10 Destroyed
@github-actions github-actions bot temporarily deployed to PR-18-Preview December 8, 2021 21:13 Destroyed
@V3lop5 V3lop5 added the enhancement New feature or request label Dec 8, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 8, 2021 21:32 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 8, 2021 21:39 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 9, 2021 08:45 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 9, 2021 08:49 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 9, 2021 09:06 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-18-Preview December 9, 2021 09:23 Destroyed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2021

Unit Test Results

  1 files  ±  0    1 suites  ±0   17s ⏱️ +13s
55 tests +35  55 ✔️ +35  0 💤 ±0  0 ±0 

Results for commit 619f221. ± Comparison against base commit 7aa982b.

This pull request removes 7 and adds 42 tests. Note that renamed tests count towards both.
tests.crud.test_energy_conversion ‑ test_create_energy_conversion
tests.database.test_tables ‑ test_table_consumption
tests.database.test_tables ‑ test_table_energyconversion
tests.database.test_tables ‑ test_table_energysink
tests.database.test_tables ‑ test_table_energysource
tests.database.test_tables ‑ test_table_energystorage
tests.database.test_tables ‑ test_table_generation
tests.api.test_datasets ‑ test_create_dataset
tests.api.test_datasets ‑ test_create_existing_dataset
tests.api.test_datasets ‑ test_delete_existing_dataset
tests.api.test_datasets ‑ test_update_existing_dataset
tests.api.test_energy_commodities ‑ test_create_energy_commodity
tests.api.test_energy_commodities ‑ test_create_energy_commodity_unknown_dataset
tests.api.test_energy_commodities ‑ test_create_existing_energy_commodity
tests.api.test_energy_conversions ‑ test_create_energy_conversion
tests.api.test_energy_conversions ‑ test_create_energy_conversion_unknown_commodity
tests.api.test_energy_conversions ‑ test_create_energy_conversion_unknown_dataset
…

@einfachMel einfachMel self-requested a review December 9, 2021 09:31
@github-actions github-actions bot temporarily deployed to PR-18-Preview December 9, 2021 09:31 Destroyed
@github-actions github-actions bot temporarily deployed to PR-18-Preview December 9, 2021 09:32 Destroyed
@einfachMel einfachMel merged commit 8e6a6fe into main Dec 9, 2021
@einfachMel einfachMel deleted the feature/rework-models branch December 9, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add models for dataset and (FINE-)model

3 participants