Skip to content

Fix release script grep error#37

Merged
V3lop5 merged 2 commits intomainfrom
fix/release-script
Dec 9, 2021
Merged

Fix release script grep error#37
V3lop5 merged 2 commits intomainfrom
fix/release-script

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Dec 9, 2021

Fixes #34

This PR ...

replaced grep with sed due to errors with windows git bash.

The script should now run on all platforms.


Checklist

  • nothing

Removed grep -Po due to missing cross plattform support
Added sed for retrieving current version
@V3lop5 V3lop5 added the github_actions Pull requests that update Github_actions code label Dec 9, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2021

Unit Test Results

  1 files  ±0    1 suites  ±0   17s ⏱️ ±0s
55 tests ±0  55 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit eb082e4. ± Comparison against base commit c55160c.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #37 (eb082e4) into main (02cba51) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          72       72           
  Lines        1153     1153           
=======================================
  Hits         1042     1042           
  Misses        111      111           
Flag Coverage Δ
pytest 90.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cba51...eb082e4. Read the comment docs.

@github-actions github-actions bot temporarily deployed to PR-37-Preview December 9, 2021 15:10 Destroyed
@einfachMel einfachMel self-requested a review December 9, 2021 15:20
@V3lop5 V3lop5 merged commit 7ebf47d into main Dec 9, 2021
@V3lop5 V3lop5 deleted the fix/release-script branch December 9, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grep in release.sh in Git Bash not working

3 participants