Skip to content

Added energy model#44

Merged
V3lop5 merged 11 commits intomainfrom
feature/energy-model
Dec 16, 2021
Merged

Added energy model#44
V3lop5 merged 11 commits intomainfrom
feature/energy-model

Conversation

@einfachMel
Copy link
Copy Markdown
Collaborator

@einfachMel einfachMel commented Dec 13, 2021

Fixes #32

This PR ...

Added the DB-Model for the energy_model which contains details to the FINE model and the using dataset.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@einfachMel einfachMel requested a review from V3lop5 December 13, 2021 12:54
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 13, 2021 12:57 Destroyed
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changed yearly_co2_limit from int to float
  • Made yearly_co2_limit optional

Co-authored-by: Paule <Velops01@gmail.com>
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 13, 2021 16:00 Destroyed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #44 (2770fd3) into main (87d42bd) will decrease coverage by 0.26%.
The diff coverage is 86.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   91.28%   91.02%   -0.27%     
==========================================
  Files          75       79       +4     
  Lines        1102     1170      +68     
==========================================
+ Hits         1006     1065      +59     
- Misses         96      105       +9     
Flag Coverage Δ
pytest 91.02% <86.76%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/api/endpoints/energy_models.py 71.87% <71.87%> (ø)
ensysmod/api/api.py 100.00% <100.00%> (ø)
ensysmod/crud/__init__.py 100.00% <100.00%> (ø)
ensysmod/crud/energy_model.py 100.00% <100.00%> (ø)
ensysmod/model/__init__.py 100.00% <100.00%> (ø)
ensysmod/model/energy_model.py 100.00% <100.00%> (ø)
ensysmod/schemas/__init__.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d42bd...2770fd3. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 13, 2021 16:04 Destroyed
@V3lop5 V3lop5 changed the title Feature/energy model Added energy model Dec 13, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 13, 2021 16:20 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 13, 2021 20:44 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 15, 2021 21:31 Destroyed
@V3lop5 V3lop5 added the enhancement New feature or request label Dec 16, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 16, 2021 09:52 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 16, 2021 09:58 Destroyed
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   15s ⏱️ -1s
59 tests +4  59 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 2770fd3. ± Comparison against base commit 87d42bd.

@github-actions github-actions bot temporarily deployed to PR-44-Preview December 16, 2021 11:18 Destroyed
@V3lop5 V3lop5 merged commit b087379 into main Dec 16, 2021
@V3lop5 V3lop5 deleted the feature/energy-model branch December 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add database models for energy model

3 participants