Skip to content

Improved transmission distance creation#53

Merged
V3lop5 merged 3 commits intomainfrom
feature/distance-schemas
Dec 22, 2021
Merged

Improved transmission distance creation#53
V3lop5 merged 3 commits intomainfrom
feature/distance-schemas

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Dec 22, 2021

This PR ...

improved transmission distance creation, allowing ids or names for regions and components.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-53-Preview December 22, 2021 20:13 Destroyed
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   19s ⏱️ +3s
61 tests ±0  61 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 64aa98c. ± Comparison against base commit 6b11557.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #53 (64aa98c) into main (6b11557) will decrease coverage by 0.21%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   90.98%   90.77%   -0.22%     
==========================================
  Files          88       88              
  Lines        1365     1398      +33     
==========================================
+ Hits         1242     1269      +27     
- Misses        123      129       +6     
Flag Coverage Δ
pytest 90.77% <83.33%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/crud/energy_transmission_distance.py 78.78% <76.00%> (-8.72%) ⬇️
ensysmod/crud/base_depends_component.py 86.95% <100.00%> (+1.24%) ⬆️
ensysmod/crud/energy_transmission.py 100.00% <100.00%> (ø)
ensysmod/model/energy_transmission_distance.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_transmission_distance.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b11557...64aa98c. Read the comment docs.

@github-actions github-actions bot temporarily deployed to PR-53-Preview December 22, 2021 21:14 Destroyed
@V3lop5 V3lop5 merged commit 288d62d into main Dec 22, 2021
@V3lop5 V3lop5 deleted the feature/distance-schemas branch December 22, 2021 21:20
@V3lop5 V3lop5 added the enhancement New feature or request label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants