Skip to content

Added zip download#74

Merged
einfachMel merged 13 commits intomainfrom
feature/zip-download
Jan 17, 2022
Merged

Added zip download#74
einfachMel merged 13 commits intomainfrom
feature/zip-download

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Jan 17, 2022

Fixes #59

This PR ...

adds the ability to download a dataset.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-74-Preview January 17, 2022 08:26 Destroyed
@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-74-Preview January 17, 2022 08:31 Destroyed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #74 (e1dd40d) into main (0ea55ad) will decrease coverage by 7.49%.
The diff coverage is 27.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   90.56%   83.06%   -7.50%     
==========================================
  Files          90       93       +3     
  Lines        1558     1760     +202     
==========================================
+ Hits         1411     1462      +51     
- Misses        147      298     +151     
Flag Coverage Δ
pytest 83.06% <27.40%> (-7.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/core/file_download.py 21.73% <21.73%> (ø)
ensysmod/utils/encoders.py 22.07% <22.07%> (ø)
ensysmod/crud/base_depends_timeseries.py 58.69% <29.62%> (-41.31%) ⬇️
ensysmod/crud/energy_transmission_distance.py 71.42% <33.33%> (-10.39%) ⬇️
ensysmod/api/endpoints/datasets.py 72.13% <35.29%> (-14.24%) ⬇️
ensysmod/crud/base_depends_component.py 84.61% <75.00%> (-2.35%) ⬇️
ensysmod/crud/ts_capacity_fix.py 100.00% <100.00%> (ø)
ensysmod/crud/ts_capacity_max.py 100.00% <100.00%> (ø)
ensysmod/crud/ts_operation_rate_fix.py 100.00% <100.00%> (ø)
ensysmod/crud/ts_operation_rate_max.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea55ad...e1dd40d. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-74-Preview January 17, 2022 09:08 Destroyed
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   29s ⏱️ -3s
62 tests ±0  62 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e1dd40d. ± Comparison against base commit 0ea55ad.

@github-actions github-actions bot temporarily deployed to PR-74-Preview January 17, 2022 09:55 Destroyed
@V3lop5 V3lop5 added the enhancement New feature or request label Jan 17, 2022
@einfachMel einfachMel self-requested a review January 17, 2022 11:53
@einfachMel einfachMel merged commit f7e8b6b into main Jan 17, 2022
@einfachMel einfachMel deleted the feature/zip-download branch January 17, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add zip download for dataset

3 participants