Skip to content

Zip upload with or without index column#77

Merged
einfachMel merged 3 commits intomainfrom
feature/zip-upload-improvement
Jan 17, 2022
Merged

Zip upload with or without index column#77
einfachMel merged 3 commits intomainfrom
feature/zip-upload-improvement

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Jan 17, 2022

Fixes #73

This PR ...

zip upload should ignore index column if present.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

@github-actions

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to PR-77-Preview January 17, 2022 11:23 Destroyed
@V3lop5 V3lop5 added the enhancement New feature or request label Jan 17, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   46s ⏱️ +14s
63 tests +1  63 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit e5237a2. ± Comparison against base commit 0ea55ad.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
tests.api.test_zip_upload ‑ test_upload_dataset
tests.api.test_zip_upload ‑ test_upload_dataset[dataset-1]
tests.api.test_zip_upload ‑ test_upload_dataset[dataset-2]

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #77 (e5237a2) into main (0ea55ad) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   90.56%   90.51%   -0.06%     
==========================================
  Files          90       90              
  Lines        1558     1560       +2     
==========================================
+ Hits         1411     1412       +1     
- Misses        147      148       +1     
Flag Coverage Δ
pytest 90.51% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/core/file_upload.py 86.29% <50.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea55ad...e5237a2. Read the comment docs.

@github-actions github-actions bot temporarily deployed to PR-77-Preview January 17, 2022 11:54 Destroyed
@einfachMel einfachMel self-requested a review January 17, 2022 11:55
@einfachMel einfachMel merged commit d9f9ac1 into main Jan 17, 2022
@einfachMel einfachMel deleted the feature/zip-upload-improvement branch January 17, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zip upload should take excel files with and without index column

3 participants