Zip upload with or without index column#77
Merged
einfachMel merged 3 commits intomainfrom Jan 17, 2022
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Added test case
Contributor
Unit Test Results 1 files ±0 1 suites ±0 46s ⏱️ +14s Results for commit e5237a2. ± Comparison against base commit 0ea55ad. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 90.56% 90.51% -0.06%
==========================================
Files 90 90
Lines 1558 1560 +2
==========================================
+ Hits 1411 1412 +1
- Misses 147 148 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
einfachMel
approved these changes
Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73
This PR ...
zip upload should ignore index column if present.
Checklist
Checklist for Contributors
Unit tests are needed for new features or to reproduce the bug solved by this PR.
Checklist for Reviewers