Skip to content

Added yearly limit for sinks#88

Merged
einfachMel merged 2 commits intomainfrom
feature/yearly-limit
Jan 23, 2022
Merged

Added yearly limit for sinks#88
einfachMel merged 2 commits intomainfrom
feature/yearly-limit

Conversation

@V3lop5
Copy link
Copy Markdown
Collaborator

@V3lop5 V3lop5 commented Jan 23, 2022

Fixes #87

This PR ...

adds a yearly limit for sinks.

Can be used to limit CO2 output.


Checklist

Checklist for Contributors

  • Unit tests provided?
    Unit tests are needed for new features or to reproduce the bug solved by this PR.
  • Documentation updated?
  • Unit tests successful
  • Code smells (flake8) checked

Checklist for Reviewers

  • Read PR description
  • Check linked issue
  • Check CI/CD (build, automated tests, linting, preview build)
  • Check documentation changes
  • Add labels to PR

Added yearly limit for CO2 of 366 mio tons
@V3lop5 V3lop5 requested a review from einfachMel January 23, 2022 20:07
@einfachMel einfachMel added the enhancement New feature or request label Jan 23, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

  1 files  ±0    1 suites  ±0   43s ⏱️ -14s
63 tests ±0  63 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ccfb29e. ± Comparison against base commit 3d7d244.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #88 (ccfb29e) into main (3d7d244) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   83.03%   83.04%   +0.01%     
==========================================
  Files          93       93              
  Lines        1762     1764       +2     
==========================================
+ Hits         1463     1465       +2     
  Misses        299      299              
Flag Coverage Δ
pytest 83.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ensysmod/model/energy_sink.py 100.00% <100.00%> (ø)
ensysmod/schemas/energy_sink.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7d244...ccfb29e. Read the comment docs.

@github-actions github-actions bot temporarily deployed to PR-88-Preview January 23, 2022 20:11 Destroyed
@einfachMel einfachMel merged commit acb9e84 into main Jan 23, 2022
@einfachMel einfachMel deleted the feature/yearly-limit branch January 23, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add yearly limit to sink

3 participants