Update to PySAm > 7.1.0 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@thedavidwhiteside for your review on this, would you mind double checking nothing else needs to be updated with the Docker/database set up and/or Cloud files? I pinned the PySAM version in both the build environment and the dg3n.yml environment, but just want to make sure there isn't anywhere else this update needs to be reflected that I may have missed! |
Removed leftover commented out code. Removed "thirdPartyOwnership" assignment for utility_bill_without_system because 'elec_cost_without_system' function was removed in 7.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies code in financial_functions.py to remove or update renamed and removed functions from version 7.1+ of PySAM. Includes updated environment file for this change where PySAM is pinned at
=7.1.0.Additionally, includes the updates to add "drop_dupllicates" where needed and can close #61
Uses code first added by and can close #77