Skip to content

Inconsistency in soiling recovery between half_norm_clean and random_clean #234

@mdeceglie

Description

@mdeceglie

Describe the bug
When a long invalid interval is made up of a string of shorter invalid intervals, half_norm_clean and random_clean in soiling.soiling_srr() behave differently. random_clean allows recovery between invalid intervals.

Expected behavior
Both random_clean and half_norm_clean should treat the entire chain of invalid intervals as a single valid interval without recoveries until the next valid interval is encountered.

Screenshots
Screen Shot 2020-11-10 at 3 43 48 PM

Zoom in on the random_clean case shows unexpected recoveries:
Screen Shot 2020-11-10 at 3 44 34 PM

Additional context
Note the example was generated with a partially complete version of the updates from #199 which changes the behavior to retain invalid intervals at beginning and end of dataset

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions