Skip to content

Conversation

@cdeline
Copy link
Collaborator

@cdeline cdeline commented Jul 31, 2020

Merging development into master for 2.0 beta release.

mdeceglie and others added 30 commits October 12, 2018 14:38
min_count was added as an argument for dataframe.resample().sum() in 0.22.0
Changes in step 0:
-use interpolate to resample the dataframe
-use new energy_from_power() function
This is more appropriate and versatile than a float with implied units
converting to integer index under the hood proves much faster than relying on pandas timestamps
enforce column order in expected df
New version of energy_from_power and incorporation into normalization
kandersolar and others added 26 commits April 20, 2020 12:29
* tentative workaround for pandas 1.0.0 reindexing bug

* Bump requirements to Pandas <= 1.0.0 for Travis upgrade-strategy=eager pytests

* update pandas req to exclude 1.0.0, 1.0.1

* Revert "tentative workaround for pandas 1.0.0 reindexing bug"

This reverts commit 9b69a9d.

* setup.py version lists are combined with AND, so <1.0.0, >=1.0.2 wasn't valid

Co-authored-by: cdeline <chris.deline@nrel.gov>
* convert README.md to ReSt in index.rst, move images folder into sphinx source

* Fix formatting, fix conf.py images folder

* Fix crosslinks and image size

* mention soiling

* another crosslink

* pare down readme.md

* incorporate new rdtools draft mission statement

* fix typo

* make introductions more approachable to non-specialists

* docs cleanup

* improve contributing notes

* drop m2r requirement since index.rst isn't generated from readme.md anymore

* remove m2r from conf.py

* requested changes

* hyphen
* Remove conflicting reqs

Some packages were specified in both notebook_requirements.txt and requirements.txt. In some cases versions conflicted.

* Update requirements.txt with indirect requirements

* Run notebook

* Add a note to first install requirements.txt

* Notebook updates

-Add directions to install both requirement files
-Incorporate bugfix from #166

* Changelog update

* Apply suggestions to changelog

Co-Authored-By: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
…_test.py (#152)

* Create irradiance_rescale_test.py

* pep8 spaces

* NameError -> UnboundLocalError

* expose convergence_threshold and default method to 'iterative'

* bugfix

* allow max_iterations=0

* bugfix

* changelog

Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
* Closes #129 bug for invalid soiling intervals

* changelog entry

* Add a test to catch nan soiling interval bug

* clean up comment indentation
* fix precipitation frequency bug

* doc typo
* Add normalized_filter() function to replace the mannual filter in example

* update docstring

* add entry to api.rst

* update changelog

* update lower bound to 0.01

* changelog for notebook changes

* add normalized_filter test to exercise default lower bound

Co-authored-by: Michael Deceglie <michael.deceglie@nrel.gov>
* rename srr_analysis to SRRAnalysis

* formatting fix

* changelog
* remove __future__ imports

* normalize_with_sapm duplicate lines

* setup.py status from beta to production/stable

* Delete build.bat

* copyright to 2020 in license and sphinx conf
* changelog for energy_from_power, normalize_with_x

* revise changelog
* migrate to pvlib >=0.7.0

* update SAPM normalization docstrings to mention racking_model and module_type

* update sapm normalization test to specify module_type

* bump docs pvlib requirement to 0.7.1

* Update rdtools/normalization.py

Co-Authored-By: Cliff Hansen <cwhanse@sandia.gov>

* don't use keyword names for sapm_celltemp

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
* tentative fix

* fix slash

* include branch logic based on RTD version

* small improvement

* omit GH link element if not building development or master

* change github link text to reflect the destination branch

* link changelog page to changelog GH folder instead of the template rst file

* bugfix
* Add normalize_with_expected_power() and refactor normalization module

* make minor adjustments to normalize_with_expected_power

* Add tests for normalize_with_expected_power

* update changelog

* update docstring

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

* Change test file name

* code formatting fixes

* simplify conditional

* return energy and insolation on same index

* minor changelog update

* add new function to __init__.py and api.rst

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
* Create degradation_and_soiling_example_sanyo.ipynb

* various typos

* change weather columns based on inspection; rename nz_mask to normalized_mask; improve soiling analysis

* bump pandas, pvlib, and statsmodels versions in requirements.txt

* add discussion; rerun notebook

* rerun original notebook with new requirements to remove warnings

* update pvlib links in notebooks to fix rendering on RTD

* use sanyo example for the RTD page

* changelog

* clean up labeling

* Notebook updates

-Update the notebook to use a more pronounced soiling signal
-Comment updates
-use normalized_filter()
-Use default behavior of infer_freq() and energy_from_power()

* Update docs/degradation_and_soiling_example_pvdaq_4.ipynb

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

* Update docs/degradation_and_soiling_example_pvdaq_4.ipynb

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

* Update notebook to use new normalize_with_expected_power()

* limit notebook line length to 90 characters

* Update notebook with data location on datahub

* add pickle to gitignore

* Cache data and fix typo

Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
* add logo to index.rst

* Update logo_horizontal_highres.png
* Add logo to readme

* Shrink logo
* remove "clean_wo_precip", add "clean_criterion"

* loop to cumulative sum

* missed some changes

* add min_interval_length parameter to SRR

* clean up code formatting

* Move clean event outage and consecutive day logic to after cleaning events are established

* Add precip and shift options for clean_criterion

* Add precip_threshold

* Update precipitation cleaning detection logic

Use a three day window only for precip_and_shift case

* Update docstrings about when precipitation is used

* update soiling test for precip behavior

* rerun notebooks

pvdaq4 notebook unaffected

* break a docstring line

* update the changelog

* docstring typo

* change log typo fix

Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>

* Review updates

* splat kwargs in test

* remove random_seed

Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
* change threshold, add warning, update tests

* fix how exclusion warning is calculated, rerun notebooks

* changelog
* Overview update

I suggest slightly rephrasing the overview.

* Add change to readme
* Create pull_request_template.md

* add default github templates

* improvements from review
* first pass at pvterms compat

* change back to `gamma_pdc`

* docstring update power->energy

* Capitalize Celsius

* dc_power to power_dc (local variable)

* modeled_irrad to irrad_sim

* 1time_series` to `power`

* add simultated to docstring

* update test with gamma_pdc

* Fix failing tests Possibly related to a pandas update rather than anything in RdTools

* Update soiling attributes

* pvwatts kwargs docstring update

* Updated example notebooks: 'tempco' = 'gamma_pdc'; 'wind' = 'wind_speed'

* Pandas > 1.0 requires explicit registering of matplotlib converters.

* update normalize_with_pvwatts and clearsky_pvwatts_kws keywords. Pref-> power_dc_rated.

* Add sphinx requirements to requirements.txt

* Update API example in index.rst.  Add #185 updates to whatsnew

* Add specific kwarg values that have changed

Co-authored-by: Michael Deceglie <mdeceglie@users.noreply.github.com>
Co-authored-by: cdeline <chris.deline@nrel.gov>
@kandersolar
Copy link
Member

@cdeline a couple suggested to-dos before merging this:

  • Update the header in docs/sphinx/source/changelog/v2.0.0.rst for the release date
  • Maybe rename docs/sphinx/source/changelog/v2.0.0.rst to v2.0.0b0.rst, and update the associated .. include:: in docs/sphinx/source/changelog.rst?

@cdeline
Copy link
Collaborator Author

cdeline commented Jul 31, 2020

Thanks @kanderso-nrel and @mdeceglie . Tests are passing, release notes are updated. I'm going to merge this later today. I'll wait until next week to tag it so any last minute changes can be incorporated.

@cdeline cdeline merged commit 8f00cd4 into master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants