fix link #127

radekosmulski · 2022-06-27T01:57:13Z

No description provided.

nvidia-merlin-bot · 2022-06-27T01:57:31Z

Click to view CI Results

GitHub pull request #127 of commit 5e8952d5c15464070585746a08873483e02b3f4a, no merge conflicts.
Running as SYSTEM
Setting status of 5e8952d5c15464070585746a08873483e02b3f4a to PENDING with url https://10.20.13.93:8080/job/merlin_systems/111/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/127/*:refs/remotes/origin/pr/127/* # timeout=10
 > git rev-parse 5e8952d5c15464070585746a08873483e02b3f4a^{commit} # timeout=10
Checking out Revision 5e8952d5c15464070585746a08873483e02b3f4a (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 5e8952d5c15464070585746a08873483e02b3f4a # timeout=10
Commit message: "fix link"
 > git rev-list --no-walk 033a5bc565231e389008c27cf7f2787690df687b # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins2574688816421798596.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 14 items / 1 error / 2 skipped
==================================== ERRORS ====================================

_____________ ERROR collecting tests/unit/systems/test_ensemble.py _____________

ImportError while importing test module '/var/jenkins_home/workspace/merlin_systems/systems/tests/unit/systems/test_ensemble.py'.

Hint: make sure your test modules/packages have valid Python names.

Traceback:

/usr/lib/python3.8/importlib/init.py:127: in import_module

return _bootstrap._gcd_import(name[level:], package, level)

tests/unit/systems/test_ensemble.py:23: in 

import xgboost

E   ModuleNotFoundError: No module named 'xgboost'

=============================== warnings summary ===============================

../../../.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18

/var/jenkins_home/.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18: DeprecationWarning: The nvtabular.framework_utils module is being replaced by the Merlin Models library. Support for importing from nvtabular.framework_utils is deprecated, and will be removed in a future version. Please consider using the models and layers from Merlin Models instead.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

ERROR tests/unit/systems/test_ensemble.py

!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

==================== 2 skipped, 1 warning, 1 error in 2.77s ====================

Build step 'Execute shell' marked build as failure

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/systems/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_systems] $ /bin/bash /tmp/jenkins6937634916277111254.sh

github-actions · 2022-06-27T02:01:55Z

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-127

oliverholworthy · 2022-06-27T08:47:41Z

README.md

 ```

-Refer to the [Merlin Systems Example Notebooks](http://github.io/NVIDIA-Merlin/systems/main/examples/README.html) for a notebook that serves a ranking models ensemble.
+Refer to the [Merlin Systems Example Notebooks](https://github.com/NVIDIA-Merlin/systems/tree/main/examples) for a notebook that serves a ranking models ensemble.


We could simplify this link further to ./examples/ if we want the link to be consistent with the commit being viewed.

wow, nice one! 🙌 didn't realize you could reference locations on github like this, change made

The examples directory is a special case because the directory is valuable to folks who browse the repository and to include the notebooks in the documentation. Because the examples/README.md is renamed during the doc build to examples/index.md, we get an examples/index.html and the index file is served by default. Hopefully that doesn't sound too magical.

https://github.com/NVIDIA-Merlin/systems/tree/main/docs#special-considerations-for-examples-and-copydirs

Looks good and thank you.

nvidia-merlin-bot · 2022-06-27T09:41:19Z

Click to view CI Results

GitHub pull request #127 of commit c06e88c5289b7ee494c9251d032a0a1aff95944f, no merge conflicts.
Running as SYSTEM
Setting status of c06e88c5289b7ee494c9251d032a0a1aff95944f to PENDING with url https://10.20.13.93:8080/job/merlin_systems/112/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/127/*:refs/remotes/origin/pr/127/* # timeout=10
 > git rev-parse c06e88c5289b7ee494c9251d032a0a1aff95944f^{commit} # timeout=10
Checking out Revision c06e88c5289b7ee494c9251d032a0a1aff95944f (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
Commit message: "Update README.md"
 > git rev-list --no-walk 5e8952d5c15464070585746a08873483e02b3f4a # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins8712363033355917160.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 14 items / 1 error / 2 skipped
==================================== ERRORS ====================================

_____________ ERROR collecting tests/unit/systems/test_ensemble.py _____________

ImportError while importing test module '/var/jenkins_home/workspace/merlin_systems/systems/tests/unit/systems/test_ensemble.py'.

Hint: make sure your test modules/packages have valid Python names.

Traceback:

/usr/lib/python3.8/importlib/init.py:127: in import_module

return _bootstrap._gcd_import(name[level:], package, level)

tests/unit/systems/test_ensemble.py:23: in 

import xgboost

E   ModuleNotFoundError: No module named 'xgboost'

=============================== warnings summary ===============================

../../../.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18

/var/jenkins_home/.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18: DeprecationWarning: The nvtabular.framework_utils module is being replaced by the Merlin Models library. Support for importing from nvtabular.framework_utils is deprecated, and will be removed in a future version. Please consider using the models and layers from Merlin Models instead.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

ERROR tests/unit/systems/test_ensemble.py

!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

==================== 2 skipped, 1 warning, 1 error in 3.03s ====================

Build step 'Execute shell' marked build as failure

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/systems/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_systems] $ /bin/bash /tmp/jenkins8139594683395732075.sh

radekosmulski · 2022-06-27T09:42:31Z

rerun tests

nvidia-merlin-bot · 2022-06-27T09:42:48Z

Click to view CI Results

GitHub pull request #127 of commit c06e88c5289b7ee494c9251d032a0a1aff95944f, no merge conflicts.
GitHub pull request #127 of commit c06e88c5289b7ee494c9251d032a0a1aff95944f, no merge conflicts.
Running as SYSTEM
Setting status of c06e88c5289b7ee494c9251d032a0a1aff95944f to PENDING with url https://10.20.13.93:8080/job/merlin_systems/113/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/127/*:refs/remotes/origin/pr/127/* # timeout=10
 > git rev-parse c06e88c5289b7ee494c9251d032a0a1aff95944f^{commit} # timeout=10
Checking out Revision c06e88c5289b7ee494c9251d032a0a1aff95944f (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
Commit message: "Update README.md"
 > git rev-list --no-walk c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins16741989864396828414.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 14 items / 1 error / 2 skipped
==================================== ERRORS ====================================

_____________ ERROR collecting tests/unit/systems/test_ensemble.py _____________

ImportError while importing test module '/var/jenkins_home/workspace/merlin_systems/systems/tests/unit/systems/test_ensemble.py'.

Hint: make sure your test modules/packages have valid Python names.

Traceback:

/usr/lib/python3.8/importlib/init.py:127: in import_module

return _bootstrap._gcd_import(name[level:], package, level)

tests/unit/systems/test_ensemble.py:23: in 

import xgboost

E   ModuleNotFoundError: No module named 'xgboost'

=============================== warnings summary ===============================

../../../.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18

/var/jenkins_home/.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18: DeprecationWarning: The nvtabular.framework_utils module is being replaced by the Merlin Models library. Support for importing from nvtabular.framework_utils is deprecated, and will be removed in a future version. Please consider using the models and layers from Merlin Models instead.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

ERROR tests/unit/systems/test_ensemble.py

!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

==================== 2 skipped, 1 warning, 1 error in 2.82s ====================

Build step 'Execute shell' marked build as failure

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/systems/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_systems] $ /bin/bash /tmp/jenkins17011240646640242157.sh

radekosmulski · 2022-06-27T12:21:02Z

rerun tests

nvidia-merlin-bot · 2022-06-27T12:21:19Z

Click to view CI Results

GitHub pull request #127 of commit c06e88c5289b7ee494c9251d032a0a1aff95944f, no merge conflicts.
GitHub pull request #127 of commit c06e88c5289b7ee494c9251d032a0a1aff95944f, no merge conflicts.
Running as SYSTEM
Setting status of c06e88c5289b7ee494c9251d032a0a1aff95944f to PENDING with url https://10.20.13.93:8080/job/merlin_systems/114/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/127/*:refs/remotes/origin/pr/127/* # timeout=10
 > git rev-parse c06e88c5289b7ee494c9251d032a0a1aff95944f^{commit} # timeout=10
Checking out Revision c06e88c5289b7ee494c9251d032a0a1aff95944f (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
Commit message: "Update README.md"
 > git rev-list --no-walk c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins8007024732752815066.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 14 items / 1 error / 2 skipped
==================================== ERRORS ====================================

_____________ ERROR collecting tests/unit/systems/test_ensemble.py _____________

ImportError while importing test module '/var/jenkins_home/workspace/merlin_systems/systems/tests/unit/systems/test_ensemble.py'.

Hint: make sure your test modules/packages have valid Python names.

Traceback:

/usr/lib/python3.8/importlib/init.py:127: in import_module

return _bootstrap._gcd_import(name[level:], package, level)

tests/unit/systems/test_ensemble.py:23: in 

import xgboost

E   ModuleNotFoundError: No module named 'xgboost'

=============================== warnings summary ===============================

../../../.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18

/var/jenkins_home/.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18: DeprecationWarning: The nvtabular.framework_utils module is being replaced by the Merlin Models library. Support for importing from nvtabular.framework_utils is deprecated, and will be removed in a future version. Please consider using the models and layers from Merlin Models instead.

warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

=========================== short test summary info ============================

ERROR tests/unit/systems/test_ensemble.py

!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

==================== 2 skipped, 1 warning, 1 error in 2.83s ====================

Build step 'Execute shell' marked build as failure

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/systems/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_systems] $ /bin/bash /tmp/jenkins1347626417856293851.sh

radekosmulski · 2022-06-27T12:25:42Z

mhmm so it seems the tests are failing on import of xgboost, so something must have changed with the CI container? these tests must have passed somehow for the xgboost import to be merged in

jperez999 · 2022-06-27T13:34:36Z

rerun tests

nvidia-merlin-bot · 2022-06-27T13:38:09Z

Click to view CI Results

GitHub pull request #127 of commit c06e88c5289b7ee494c9251d032a0a1aff95944f, no merge conflicts.
Running as SYSTEM
Setting status of c06e88c5289b7ee494c9251d032a0a1aff95944f to PENDING with url https://10.20.13.93:8080/job/merlin_systems/115/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/127/*:refs/remotes/origin/pr/127/* # timeout=10
 > git rev-parse c06e88c5289b7ee494c9251d032a0a1aff95944f^{commit} # timeout=10
Checking out Revision c06e88c5289b7ee494c9251d032a0a1aff95944f (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
Commit message: "Update README.md"
 > git rev-list --no-walk c06e88c5289b7ee494c9251d032a0a1aff95944f # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins9201396229299800286.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 47 items
tests/unit/test_version.py .                                             [  2%]

tests/unit/systems/test_ensemble.py ....                                 [ 10%]

tests/unit/systems/test_ensemble_ops.py ..                               [ 14%]

tests/unit/systems/test_export.py .                                      [ 17%]

tests/unit/systems/test_graph.py .                                       [ 19%]

tests/unit/systems/test_inference_ops.py ..                              [ 23%]

tests/unit/systems/test_op_runner.py ....                                [ 31%]

tests/unit/systems/test_tensorflow_inf_op.py ...                         [ 38%]

tests/unit/systems/fil/test_fil.py ..........................            [ 93%]

tests/unit/systems/fil/test_forest.py ...                                [100%]
=============================== warnings summary ===============================

../../../.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18

/var/jenkins_home/.local/lib/python3.8/site-packages/nvtabular/framework_utils/init.py:18: DeprecationWarning: The nvtabular.framework_utils module is being replaced by the Merlin Models library. Support for importing from nvtabular.framework_utils is deprecated, and will be removed in a future version. Please consider using the models and layers from Merlin Models instead.

warnings.warn(
tests/unit/systems/test_ensemble.py::test_workflow_tf_e2e_config_verification[parquet]

tests/unit/systems/test_ensemble.py::test_workflow_tf_e2e_multi_op_run[parquet]

tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

tests/unit/systems/test_inference_ops.py::test_workflow_op_validates_schemas[parquet]

tests/unit/systems/test_inference_ops.py::test_workflow_op_exports_own_config[parquet]

tests/unit/systems/test_op_runner.py::test_op_runner_loads_config[parquet]

tests/unit/systems/test_op_runner.py::test_op_runner_loads_multiple_ops_same[parquet]

tests/unit/systems/test_op_runner.py::test_op_runner_loads_multiple_ops_same_execute[parquet]

tests/unit/systems/test_op_runner.py::test_op_runner_single_node_export[parquet]

/usr/local/lib/python3.8/dist-packages/cudf/core/frame.py:384: UserWarning: The deep parameter is ignored and is only included for pandas compatibility.

warnings.warn(
tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

/var/jenkins_home/workspace/merlin_systems/systems/merlin/systems/triton/export.py:304: UserWarning: Column x is being generated by NVTabular workflow  but is unused in test_name_tf model

warnings.warn(
tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

/var/jenkins_home/workspace/merlin_systems/systems/merlin/systems/triton/export.py:304: UserWarning: Column y is being generated by NVTabular workflow  but is unused in test_name_tf model

warnings.warn(
tests/unit/systems/test_export.py::test_export_run_ensemble_triton[tensorflow-parquet]

/var/jenkins_home/workspace/merlin_systems/systems/merlin/systems/triton/export.py:304: UserWarning: Column id is being generated by NVTabular workflow  but is unused in test_name_tf model

warnings.warn(
tests/unit/systems/fil/test_fil.py::test_binary_classifier_default[sklearn_forest_classifier-get_model_params4]

tests/unit/systems/fil/test_fil.py::test_binary_classifier_with_proba[sklearn_forest_classifier-get_model_params4]

tests/unit/systems/fil/test_fil.py::test_multi_classifier[sklearn_forest_classifier-get_model_params4]

tests/unit/systems/fil/test_fil.py::test_regressor[sklearn_forest_regressor-get_model_params4]

tests/unit/systems/fil/test_fil.py::test_model_file[sklearn_forest_regressor-checkpoint.tl]

/usr/local/lib/python3.8/dist-packages/sklearn/utils/deprecation.py:103: FutureWarning: Attribute n_features_ was deprecated in version 1.0 and will be removed in 1.2. Use n_features_in_ instead.

warnings.warn(msg, category=FutureWarning)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

================= 47 passed, 18 warnings in 196.54s (0:03:16) ==================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/systems/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[merlin_systems] $ /bin/bash /tmp/jenkins1879004453127632650.sh

fix link

5e8952d

radekosmulski requested a review from mikemckiernan June 27, 2022 01:57

radekosmulski requested a review from karlhigley June 27, 2022 01:57

radekosmulski added the documentation Improvements or additions to documentation label Jun 27, 2022

oliverholworthy reviewed Jun 27, 2022

View reviewed changes

Update README.md

c06e88c

oliverholworthy approved these changes Jun 27, 2022

View reviewed changes

mikemckiernan approved these changes Jun 27, 2022

View reviewed changes

jperez999 merged commit 8c92916 into main Jun 27, 2022

fix link #127

fix link #127

Uh oh!

Conversation

radekosmulski commented Jun 27, 2022

Uh oh!

nvidia-merlin-bot commented Jun 27, 2022

Uh oh!

github-actions bot commented Jun 27, 2022

Documentation preview

Uh oh!

oliverholworthy Jun 27, 2022

Choose a reason for hiding this comment

Uh oh!

radekosmulski Jun 27, 2022

Choose a reason for hiding this comment

Uh oh!

mikemckiernan Jun 27, 2022

Choose a reason for hiding this comment

Uh oh!

nvidia-merlin-bot commented Jun 27, 2022

Uh oh!

radekosmulski commented Jun 27, 2022

Uh oh!

nvidia-merlin-bot commented Jun 27, 2022

Uh oh!

radekosmulski commented Jun 27, 2022

Uh oh!

nvidia-merlin-bot commented Jun 27, 2022

Uh oh!

radekosmulski commented Jun 27, 2022

Uh oh!

jperez999 commented Jun 27, 2022

Uh oh!

nvidia-merlin-bot commented Jun 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants