feast should return np.float32 not np.float by default #178
Conversation
Click to view CI ResultsGitHub pull request #178 of commit 0966faaf2c6ab6b6d75b292dcde6305240620eb5, no merge conflicts.
Running as SYSTEM
Setting status of 0966faaf2c6ab6b6d75b292dcde6305240620eb5 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/304/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/178/*:refs/remotes/origin/pr/178/* # timeout=10
> git rev-parse 0966faaf2c6ab6b6d75b292dcde6305240620eb5^{commit} # timeout=10
Checking out Revision 0966faaf2c6ab6b6d75b292dcde6305240620eb5 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 0966faaf2c6ab6b6d75b292dcde6305240620eb5 # timeout=10
Commit message: "feast should return np.float32 not np.float by default"
> git rev-list --no-walk f2e9c42ea78dfb4c46c478aaf8d9161362e04f7a # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins8318527460320415350.sh
PYTHONPATH=:/usr/local/lib/python3.8/dist-packages/:/usr/local/hugectr/lib:/var/jenkins_home/workspace/merlin_systems/systems
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 68 items
|
Documentation preview |
A potential solution for #177 (still to be verified).
We return
np.floatwhich is a deprecated alias fornp.float64. However, when we infer the input schemas inPredictTensorflow, continuously valued model inputs arenp.float32, thus we get a schema mis-match when we chain QueryFeast into PredictTensorflow.