Update compute_dims function to use new shape property
#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
karlhigley
approved these changes
Feb 13, 2023
oliverholworthy
commented
Feb 14, 2023
| ) -> Schema: | ||
| """Describe the operator's outputs""" | ||
| return Schema([ColumnSchema("ordered_ids", dtype=np.int32, is_list=True, is_ragged=False)]) | ||
| return Schema([ColumnSchema("ordered_ids", dtype=np.int32, dims=(None, 1))]) |
Contributor
Author
There was a problem hiding this comment.
We now need to specify the second dimensiion output size as 1 so that the output is fixed size and returns a single ordered_ids in the Triton config instead of split into values/lengths
Contributor
Author
There was a problem hiding this comment.
(None, 1) matches the return shape of (-1, 1) from the transform method. There may be some follow-up work to make this operator work on more than one batch at a time instead of only the one that it assumes currently.
Contributor
There was a problem hiding this comment.
Good catch! Agreed on the follow-up work, that’s been on our list for a while but we decided it would be easier to tackle after we did the shapes migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
compute_dimsfunction to use new shape property.