Remove the Triton-specific Workflow execution code #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have an existing set of DAG executors that are perfectly capable of running Workflows on a single dataframe without Dask, we can remove the Triton-specific Workflow execution code and work on optimizing the executors from Core instead of incrementally refactoring this code to merge it with that code.
oliverholworthy
approved these changes
Mar 31, 2023
This tests depended on having a Workflow operator exported as a separate model, so they broke when Workflows started to be run as normal Python ops in the executors.
Documentation preview |
karlhigley
added a commit
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have an existing set of DAG executors that are perfectly capable of running Workflows on a single dataframe without Dask, we can remove the Triton-specific Workflow execution code and work on optimizing the executors from Core instead of incrementally refactoring this code to align and merge it with the executors.