Conversation
akoumpa
force-pushed
the
akoumparouli/rank0_logging
branch
from
81a59dc to
e27ee79
Compare
Contributor
Author
|
/ok to test f7be862 |
akoumpa
force-pushed
the
akoumparouli/rank0_logging
branch
from
f7be862 to
bac4fe5
Compare
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumparouli/rank0_logging
branch
from
bac4fe5 to
5a59195
Compare
Contributor
Author
|
/ok to test 5a59195 |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 6295aec |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 118a9de |
torsli
pushed a commit
that referenced
this pull request
Jun 10, 2025
* fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * add RankFilter Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * add docstring Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * rename env var Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * switch from print to logging Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * add peak memory Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * disable logging in ranks > 0 Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having the following
this PR adds a RankFilter that's used inside logging, and therefore the code now looks like
internally, logging will apply the RankFilter and will only log from rank 0. If necessary, the user can pass the
all_ranksattribute to get a log from all ranks.As a result, calls to
printshould be avoided in favor oflogging.info