Skip to content

fix: nemotron flash 1b in v5#1569

Closed
akoumpa wants to merge 6 commits intomainfrom
akoumparouli/fix_nemotron_flash_1b_in_v5
Closed

fix: nemotron flash 1b in v5#1569
akoumpa wants to merge 6 commits intomainfrom
akoumparouli/fix_nemotron_flash_1b_in_v5

Conversation

@akoumpa
Copy link
Copy Markdown
Contributor

@akoumpa akoumpa commented Mar 17, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

akoumpa added 5 commits March 17, 2026 14:33
@akoumpa
fix
5c0e836 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
update
4e0a1e5 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
use by dtype by default
e423649 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
test
43ee79c 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
add nemotron flash to v5
4d07950 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Mar 17, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 17, 2026

/ok to test 4d07950

@akoumpa
cp
7cf1364 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Mar 17, 2026

/ok to test 7cf1364

@akoumpa akoumpa self-assigned this Mar 30, 2026
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Apr 2, 2026

fixed in #1631

@akoumpa akoumpa closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuiyingLi HuiyingLi Awaiting requested review from HuiyingLi HuiyingLi will be requested when the pull request is marked ready for review HuiyingLi is a code owner

@adil-a adil-a Awaiting requested review from adil-a adil-a will be requested when the pull request is marked ready for review adil-a is a code owner

@hemildesai hemildesai Awaiting requested review from hemildesai hemildesai will be requested when the pull request is marked ready for review hemildesai is a code owner

@ZhiyuLi-Nvidia ZhiyuLi-Nvidia Awaiting requested review from ZhiyuLi-Nvidia ZhiyuLi-Nvidia will be requested when the pull request is marked ready for review ZhiyuLi-Nvidia is a code owner

@pthombre pthombre Awaiting requested review from pthombre pthombre will be requested when the pull request is marked ready for review pthombre is a code owner

@athitten athitten Awaiting requested review from athitten athitten will be requested when the pull request is marked ready for review athitten is a code owner

@zyzhou5 zyzhou5 Awaiting requested review from zyzhou5 zyzhou5 will be requested when the pull request is marked ready for review zyzhou5 is a code owner

Assignees

@akoumpa akoumpa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@akoumpa