-
Notifications
You must be signed in to change notification settings - Fork 140
ci: Update to transformers v5.5 #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6f9044f
Update to transformers v5.5
3287ae3
Update uv lock
3afed33
Fix for gemma4, nemotron, dsv3 and unit tests
athitten 5fabb2d
_reinit_rope_buffers for gemma3 and enable gemma4 tests
athitten 523b8ed
Update uv lock
97674c1
Add _reinit_non_persistent_buffers to cover all non_persistent_buffers
athitten 14ce6ee
materialize params on meta device only and handle gemma3 SigLIP posit…
athitten db1479c
Remove cache_position arg from Qwen3_5MoeGatedDeltaNet.forward()
503840d
Run L2_HF_PEFT only with debug info
athitten d76c944
Add gemma3 fallback key mappings to be compatible with transformers5.5
athitten b69b337
Remove need_post_shard_init from should_load_checkpoint
athitten 9c31a2e
Revert need_post_shard_init
athitten 47c39ee
Fix Gemma3 VLM checkpoint loading with transformers 5.5
athitten 9be524c
Uncomment all tests and add skipped code test_peft_vlm.py
athitten 56260fd
Fix order of tests
athitten d5e5250
Minor fix cicd-main.yml
athitten 6cab330
Make _reinit_non_persistent_buffers model specific
athitten f3b7189
Fix lint error
athitten e1bf007
Update uv lock
2cd5ee6
pass model_type to _reinit_non_persistent_buffers
akoumpa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note-to-self: I think this is ok for the time being, but long term, it might be a good idea to move all the model-specific patching under nemo_automodel/components/models/, so that each model has its own patches. No action is needed.