Conversation
…y were over-specifying implementation details. The implementation of get_fsdp_dp_mesh (nemo_automodel/components/distributed/mesh_utils.py:414) correctly probes axis sizes via device_mesh[cp_name].size() and device_mesh[dp_replicate_name].size() before slicing, which makes 2–3 __getitem__ calls total. The tests asserted assert_called_once_with(...) / assert_not_called(), which conflicts with those size probes. Fix in tests/unit_tests/distributed/test_mesh_utils.py: - Lines 364, 379, 393: assert_called_once_with → assert_any_call. The existing result._key and result._mesh is mesh assertions already verify the real guarantees (correct slice key + shared root mesh). - Lines 414–415: replaced __getitem__.assert_not_called() with a filter that only forbids tuple-key direct slices (the actual guarantee), allowing bare-name size probes. Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test efa7d4a |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 7e8807d |
3 tasks
Contributor
Author
|
/ok to test c921559 |
Contributor
Author
all yamls should exist now |
adil-a
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information