fix: add embed_vision to MULTIMODAL_SUFFIXES and set lbs=2 for Gemma4 PP2 recipe#1911
Merged
HuiyingLi merged 2 commits intoNVIDIA-NeMo:mainfrom Apr 20, 2026
Merged
Conversation
…signment Signed-off-by: khazic <khazzz1c@gmail.com>
…= pp_stages Signed-off-by: khazic <khazzz1c@gmail.com>
50d6310 to
e97b160
Compare
Contributor
|
/ok to test e97b160 |
linnanwang
pushed a commit
that referenced
this pull request
Apr 24, 2026
… PP2 recipe (#1911) * fix: add embed_vision to MULTIMODAL_SUFFIXES for Gemma4 PP stage-0 assignment Signed-off-by: khazic <khazzz1c@gmail.com> * fix: set local_batch_size=2 for PP2 recipe to ensure n_microbatches >= pp_stages Signed-off-by: khazic <khazzz1c@gmail.com> --------- Signed-off-by: khazic <khazzz1c@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Two small follow-up fixes to #1904, caught in review by @HuiyingLi: correct `embed_vision` stage-0 assignment for Gemma4 PP, and fix `local_batch_size` in the PP2 recipe to avoid a 100% pipeline bubble.
Changelog
Before your PR is "Ready for review"
Pre checks:
Additional Information