Skip to content

fix: make _get_logits pp aware in ckpt robustness#1923

Merged
akoumpa merged 1 commit intomainfrom
akoumparouli/fix_ckpt_robustness_pp
Apr 21, 2026
Merged

fix: make _get_logits pp aware in ckpt robustness#1923
akoumpa merged 1 commit intomainfrom
akoumparouli/fix_ckpt_robustness_pp

Conversation

@akoumpa
Copy link
Copy Markdown
Contributor

@akoumpa akoumpa commented Apr 20, 2026 •
edited
Loading

What does this PR do ?

fixes examples/llm_finetune/nemotron/llama3_3_nemotron_super_49B_squad.yaml but also any other PP config.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@akoumpa
make _get_logits pp aware
53b0353 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 20, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akoumpa akoumpa added the r0.4.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Apr 20, 2026
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Apr 20, 2026

/ok to test 53b0353

@akoumpa akoumpa requested a review from adil-a April 20, 2026 23:28
@akoumpa
Copy link
Copy Markdown
Contributor Author

akoumpa commented Apr 21, 2026

/claude review

@akoumpa akoumpa marked this pull request as ready for review April 21, 2026 01:54
claude[bot]
claude Bot approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoumpa akoumpa merged commit 83dfbc7 into main Apr 21, 2026
58 checks passed
@akoumpa akoumpa deleted the akoumparouli/fix_ckpt_robustness_pp branch April 21, 2026 05:15
akoumpa added a commit that referenced this pull request Apr 21, 2026
@svcnvidia-nemo-ci @akoumpa
cp: fix: make _get_logits pp aware in ckpt robustness (1923) into `…
401c8e5 
…r0.4.0` (#1934)

fix: make _get_logits pp aware in ckpt robustness (#1923)

make _get_logits pp aware

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
@adil-a adil-a mentioned this pull request Apr 21, 2026
Open
4 tasks
linnanwang pushed a commit that referenced this pull request Apr 24, 2026
@akoumpa @linnanwang
fix: make _get_logits pp aware in ckpt robustness (#1923)
f62712e 
make _get_logits pp aware

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] approved these changes

@adil-a adil-a Awaiting requested review from adil-a

Assignees

No one assigned

Labels

r0.4.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@akoumpa