Conversation
…1941) fix: flatten ModuleList in _extract_model_layers so AC applies to individual layers _reduce_attrs returns ModuleList objects as single items; extending layers with them meant AC code never found self_attn/mlp on a ModuleList and silently skipped all checkpointing. Flatten any ModuleList results so layers contains individual decoder layers, matching the heuristic path. Signed-off-by: khazic <khazzz1c@gmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Contributor
Author
|
/ok to test 8566f86 |
svcnvidia-nemo-ci
requested review from
ZhiyuLi-Nvidia,
adil-a,
hemildesai and
pthombre
as code owners
akoumpa
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @khazic 👋,