fix: checkpoint memory consuming layers in Nemotron 12B model#391
Merged
fix: checkpoint memory consuming layers in Nemotron 12B model#391
Conversation
ybgao-nvidia
requested review from
BoxiangW,
HuiyingLi,
adil-a and
akoumpa
as code owners
ffrujeri
force-pushed
the
nemo-rl-submodule
branch
from
0a74ab7 to
256f74c
Compare
4 tasks
ffrujeri
force-pushed
the
nemo-rl-submodule
branch
3 times, most recently
from
d99eb90 to
58ea771
Compare
ffrujeri
force-pushed
the
ybgao/fix-model-checkpointing
branch
from
6508e44 to
73ac7cc
Compare
ffrujeri
previously approved these changes
Aug 28, 2025
akoumpa
previously approved these changes
Aug 28, 2025
ffrujeri
dismissed stale reviews from akoumpa and themself
The base branch was changed.
akoumpa
previously approved these changes
Aug 28, 2025
Contributor
|
/ok to test 73ac7cc |
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
ffrujeri
force-pushed
the
ybgao/fix-model-checkpointing
branch
from
27b7c1c to
8c34b71
Compare
Contributor
|
/ok to test 8c34b71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides feature parity with this PR in RL.