fix: resolving errors in the hf decorator function#983
fix: resolving errors in the hf decorator function#983ko3n1g merged 2 commits intoNVIDIA-NeMo:mainfrom
Conversation
|
/ok to test 5c571b6 |
|
Hi @dongs0104, the signature for this function changed in |
|
Hello @hemildesai , This seems related to huggingface/transformers#40994 In pyproject.toml, the dependency currently defined as |
In order to support different versions, I was thinking something like check_model_inputs_decorator = check_model_inputs() if transformers_version >= 4.57.3 else check_model_inputs
@check_model_inputs_decorator
...What do you think? |
|
Hi @dongs0104, since we need this fix for a downstream release, I can push the change directly to this PR. Hope that's ok. |
Signed-off-by: Hemil Desai <hemild@nvidia.com>
Signed-off-by: Hemil Desai <hemild@nvidia.com>
|
/ok to test 35ffe65 |
Signed-off-by: Hemil Desai <hemild@nvidia.com> Co-authored-by: Hemil Desai <hemild@nvidia.com>
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information