ci: Optimize docker layer and uv with no cache#1444
Merged
Conversation
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| # Selective file copying before dependency installation for better layer caching | ||
| COPY pyproject.toml uv.lock /opt/Curator/ | ||
| COPY nemo_curator/__init__.py nemo_curator/package_info.py /opt/Curator/nemo_curator/ |
Contributor
There was a problem hiding this comment.
copying __init__.py might cause issues during uv sync if setuptools tries to import it, since it imports cosmos_xenna.ray_utils.cluster which isn't installed yet
Suggested change
| COPY nemo_curator/__init__.py nemo_curator/package_info.py /opt/Curator/nemo_curator/ | |
| COPY nemo_curator/package_info.py /opt/Curator/nemo_curator/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usage
# Add snippet demonstrating usageChecklist