Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ override-dependencies = [
"numpy>=2.0.0,<=2.2.0", # Override nemo-toolkits constraint of <2.0.0, upperbounds for Numba compatibility
"protobuf>=5.29.5", # Override nemo-toolkits constraint of ~=5.29.5
"setuptools>=80.10.1", # Override setuptools range in other dependencies to address CVE GHSA-58pv-8j8x-9vj2
"transformers>=4.55.2",
"transformers<=4.55.2", # Else Cosmos Embed imports fail
Comment thread
abhinavg4 marked this conversation as resolved.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing lower bound
tool.uv.override-dependencies currently sets transformers<=4.55.2, but project.dependencies still lists plain transformers (no minimum). A fresh resolve can therefore pick older transformers versions (anything <= 4.55.2), which conflicts with the PR’s goal of pinning/downgrading to 4.55.2 for Cosmos Embed compatibility and can break at runtime if Cosmos expects 4.55.x APIs. Fix by making the override an exact pin (==4.55.2) or adding the lower bound (e.g. >=4.55.2,<=4.55.2).

]


Expand Down
40 changes: 20 additions & 20 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading