Add feedback to tutorials#1476
Merged
thomasdhc merged 8 commits intoNVIDIA-NeMo:mainfrom Feb 12, 2026
Merged
Conversation
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
ayushdg
reviewed
Feb 12, 2026
Contributor
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Quick question: What's the goal of importing gpustat? Is it to check if text_cuda12 was installed or not?
Contributor
Author
|
@ayushdg yes I just chose it because it is a GPU dependency in https://github.com/NVIDIA-NeMo/Curator/blob/main/pyproject.toml#L72. Happy to swap it out or remove it though. |
ayushdg
approved these changes
Feb 12, 2026
Contributor
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Using gpustat as a proxy to check correct installation is okay for the time being. Maybe in the future we can swap this out with something more robust.
Contributor
|
Bypassing CI check as tutorials only change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.