Skip to content

Add DiT Readme.#61

Merged
sajadn merged 8 commits intomainfrom
dit_readme
Dec 1, 2025
Merged

Add DiT Readme.#61
sajadn merged 8 commits intomainfrom
dit_readme

Conversation

@sajadn
Copy link
Contributor

@sajadn sajadn commented Nov 18, 2025

  • add dit readme.

@sajadn
Add DiT Readme.
b1efcda 
Signed-off-by: sajadn <snorouzi@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

abhinavg4
abhinavg4 requested changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments also please check these comments: https://github.com/NVIDIA-NeMo/DFM/pull/38/files

@sajadn
Update DiT readme.
7bd9479 
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
@sajadn
Minor wording update.
d2659ba 
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
@sajadn sajadn requested a review from abhinavg4 November 20, 2025 23:21
abhinavg4
abhinavg4 previously approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation. Loved it. Left a few minor comments.

examples/megatron/recipes/dit/README.md Outdated
Copy link
Contributor

@abhinavg4 abhinavg4 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: packs the HF dataset into Webdataset format. Format compatible with Energon sounds something mystic

examples/megatron/recipes/dit/README.md Outdated
Copy link
Contributor

@abhinavg4 abhinavg4 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this print. Not needed

Copy link
Contributor Author

@sajadn sajadn Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want me to get rid of the whole prints of energon prepare ./?

examples/megatron/recipes/dit/README.md Outdated
Copy link
Contributor

@abhinavg4 abhinavg4 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great section. Also provide link to energon documentation for these params?

@sajadn sajadn enabled auto-merge (squash) November 21, 2025 15:57
@sajadn
minor wording update.
b2a8972 
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
sajadn and others added 2 commits November 21, 2025 09:17
@sajadn
delete warning.
633dc2e 
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
@abhinavg4
Merge branch 'main' into dit_readme
045f421
@abhinavg4
Copy link
Contributor

abhinavg4 commented Nov 21, 2025

/ok to test 045f421

abhinavg4
abhinavg4 reviewed Nov 21, 2025
View reviewed changes
examples/megatron/recipes/dit/README.md
@@ -1,77 +1,184 @@
# DiT (Diffusion Transformer) Model Setup
Copy link
Contributor

@abhinavg4 abhinavg4 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this under docs/megatron/models/DiT/dit.md

@sajadn
move to docs folder.
49fa7a1 
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
abhinavg4
abhinavg4 approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@abhinavg4
Copy link
Contributor

abhinavg4 commented Dec 1, 2025

/ok to test 7a832f6

@sajadn sajadn merged commit 2489a8e into main Dec 1, 2025
15 checks passed
lbliii pushed a commit that referenced this pull request Dec 3, 2025
@sajadn @lbliii
Add DiT Readme. (#61)
e615658 
* Add DiT Readme.

Signed-off-by: sajadn <snorouzi@nvidia.com>

* Update DiT readme.

Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>

* Minor wording update.

Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>

---------

Signed-off-by: sajadn <snorouzi@nvidia.com>
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
@chtruong814 chtruong814 deleted the dit_readme branch January 29, 2026 20:26
huvunvidia pushed a commit that referenced this pull request Feb 12, 2026
@sajadn
Add DiT Readme. (#61)
2900c24 
* Add DiT Readme.

Signed-off-by: sajadn <snorouzi@nvidia.com>

* Update DiT readme.

Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>

* Minor wording update.

Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>

---------

Signed-off-by: sajadn <snorouzi@nvidia.com>
Signed-off-by: Sajad Norouzi <snorouzi@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavg4 abhinavg4 abhinavg4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sajadn @abhinavg4

Comments