Skip to content

Report Mcore vs AutoModel#72

Merged
pablo-garay merged 4 commits intomainfrom
huvu/mcore_vs_automodel_report
Dec 3, 2025
Merged

Report Mcore vs AutoModel#72
pablo-garay merged 4 commits intomainfrom
huvu/mcore_vs_automodel_report

Conversation

@huvunvidia
Copy link
Contributor

No description provided.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

abhinavg4
abhinavg4 previously approved these changes Dec 1, 2025
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix the linitng error. Thanks

…tting and ensuring clarity in experiment overview and caveats regarding training loss fluctuations between Diffusers and Megatron-Core implementations.
@abhinavg4
Copy link
Contributor

/ok to test 452e0bc

Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@abhinavg4 abhinavg4 disabled auto-merge December 3, 2025 02:22
@abhinavg4 abhinavg4 enabled auto-merge (squash) December 3, 2025 02:22
@abhinavg4
Copy link
Contributor

/ok to test 87ac850

@pablo-garay pablo-garay disabled auto-merge December 3, 2025 02:29
@pablo-garay pablo-garay merged commit 1d8891e into main Dec 3, 2025
8 checks passed
lbliii pushed a commit that referenced this pull request Dec 3, 2025
* report for public version

* fix image size

* Update report.md for Wan 2.1 convergence comparison, correcting formatting and ensuring clarity in experiment overview and caveats regarding training loss fluctuations between Diffusers and Megatron-Core implementations.

---------

Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com>
Co-authored-by: Abhinav Garg <abhinavg@stanford.edu>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
@chtruong814 chtruong814 deleted the huvu/mcore_vs_automodel_report branch January 29, 2026 20:26
huvunvidia added a commit that referenced this pull request Feb 12, 2026
* report for public version

* fix image size

* Update report.md for Wan 2.1 convergence comparison, correcting formatting and ensuring clarity in experiment overview and caveats regarding training loss fluctuations between Diffusers and Megatron-Core implementations.

---------

Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com>
Co-authored-by: Abhinav Garg <abhinavg@stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments