Conversation
akoumpa
force-pushed
the
akoumparouli/moe_doc_fixes
branch
2 times, most recently
from
7d287fd to
499c4d2
Compare
ntajbakhsh
reviewed
Aug 7, 2024
akoumpa
force-pushed
the
akoumparouli/moe_doc_fixes
branch
from
499c4d2 to
d12d679
Compare
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumparouli/moe_doc_fixes
branch
from
d12d679 to
19b1e2c
Compare
jgerh
reviewed
Aug 9, 2024
Collaborator
jgerh
left a comment
jgerh
left a comment
There was a problem hiding this comment.
Completed the review again of the moe.rst file. Please add all copyedits for grammar, punctuation, and NeMo Framework naming conventions. Also, make the requested heading changes for Overview, Use MoE, and Configure MoE-specific Loss Function.
| @@ -4,7 +4,7 @@ Mixture of Experts | |||
| Overview | |||
Collaborator
There was a problem hiding this comment.
Delete this heading here. We will move it to another location.
Overview
|
|
||
| 2. ``moe_token_dropping`` enables selectively dropping and padding tokens for each expert to achieve | ||
| a specified capacity. | ||
| a specified capacity, similar to GShard, Switch-Transformer, and DeepSpeed-MoE. Briefly, if the number |
Collaborator
There was a problem hiding this comment.
fix run-on sentence.
moe_token_dropping enables selectively dropping and padding tokens for each expert to achieve a specified capacity. Similar to GShard, Switch-Transformer, and DeepSpeed-MoE. Briefly, if the number of tokens routed to an expert exceeds its capacity, then the exceeding tokens are dropped.
thomasdhc
approved these changes
Aug 9, 2024
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
* Moe doc fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * JG fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Moe doc fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * JG fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Moe doc fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * JG fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* Moe doc fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * JG fixes Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information