Skip to content

Comments

Cherry pick Vllm 0.6.0 integration test (10697) into r2.0.0#10760

Merged
thomasdhc merged 1 commit intor2.0.0from
cherry-pick-10697-r2.0.0
Oct 4, 2024
Merged

Cherry pick Vllm 0.6.0 integration test (10697) into r2.0.0#10760
thomasdhc merged 1 commit intor2.0.0from
cherry-pick-10697-r2.0.0

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 4, 2024

[🤖]: Hi @HuiyingLi 👋,

we've cherry picked #10697 into r2.0.0 for you! 🚀

Please review and approve this cherry pick by your convenience!

* fixes for vllm 0.5.5

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>

* vllm 0.6.0 updates

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>

* change --ptuning --lora arg

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>

* convert ptuning and lora to bool

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>

* parse arg being empty string to be false

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>

* cleanup and format

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>

---------

Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Co-authored-by: Onur Yilmaz <35306097+oyilmaz-nvidia@users.noreply.github.com>
@ko3n1g ko3n1g added the Run CICD label Oct 4, 2024
Copy link
Collaborator

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@thomasdhc thomasdhc merged commit a7b5b14 into r2.0.0 Oct 4, 2024
@thomasdhc thomasdhc deleted the cherry-pick-10697-r2.0.0 branch October 4, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants