Skip to content

modelopt=0.21.0 update#11513

Merged
janekl merged 5 commits intomainfrom
jlasek/ptq_mixtral_bugfix
Dec 31, 2024
Merged

modelopt=0.21.0 update#11513
janekl merged 5 commits intomainfrom
jlasek/ptq_mixtral_bugfix

Conversation

@janekl
Copy link
Collaborator

@janekl janekl commented Dec 9, 2024

What does this PR do ?

Collection: LLM / NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@github-actions github-actions bot added the NLP label Dec 9, 2024
@janekl janekl added the Run CICD label Dec 9, 2024
@janekl janekl requested a review from Laplasjan107 December 9, 2024 12:16
Laplasjan107
Laplasjan107 previously approved these changes Dec 9, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl changed the title Pass the number of experts to modelopt layer spec Pass the number of experts to modelopt layer spec + modelopt=0.21.0 update Dec 9, 2024
@janekl janekl added Run CICD and removed Run CICD labels Dec 10, 2024
@github-actions
Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl changed the title Pass the number of experts to modelopt layer spec + modelopt=0.21.0 update modelopt=0.21.0 update Dec 20, 2024
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is modelopt not part of requirements txt?

@janekl
Copy link
Collaborator Author

janekl commented Dec 20, 2024

Why is modelopt not part of requirements txt?

I think Eric wanted it to be only an optional requirement for NeMo in the initial integration effort (see here and here). It's also import guarded (see here, for example).

Are you suggesting to revisit this decision?

@ko3n1g
Copy link
Collaborator

ko3n1g commented Dec 20, 2024

Why is modelopt not part of requirements txt?

I think Eric wanted it to be only an optional requirement for NeMo in the initial integration effort (see here and here). It's also import guarded (see here, for example).

Are you suggesting to revisit this decision?

If this was for initial implementation then yes, let’s revisit it. But not necessarily as part of this PR. Thanks for explaining!

@janekl
Copy link
Collaborator Author

janekl commented Dec 23, 2024

This needs to be synced with an update on container side, I'll let you know once ready

@janekl janekl added Run CICD and removed Run CICD labels Dec 30, 2024
@github-actions
Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@janekl janekl merged commit fdfc9f4 into main Dec 31, 2024
191 of 194 checks passed
@janekl janekl deleted the jlasek/ptq_mixtral_bugfix branch December 31, 2024 09:22
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* Pass number of experts to modelopt layer spec

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* modelopt 0.21.0 update

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Fix too long lines

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* Pass number of experts to modelopt layer spec

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* modelopt 0.21.0 update

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Fix too long lines

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments