Conversation
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
|
[🤖]: Hi @janekl 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
ko3n1g
left a comment
There was a problem hiding this comment.
Why is modelopt not part of requirements txt?
If this was for initial implementation then yes, let’s revisit it. But not necessarily as part of this PR. Thanks for explaining! |
|
This needs to be synced with an update on container side, I'll let you know once ready |
|
[🤖]: Hi @janekl 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
* Pass number of experts to modelopt layer spec Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * modelopt 0.21.0 update Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Fix too long lines Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
* Pass number of experts to modelopt layer spec Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * modelopt 0.21.0 update Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Fix too long lines Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
What does this PR do ?
Bugfix to correctly support Mixtral for PTQ in NeMo 2.0.done in Pass the number of experts to modelopt layer spec #11607nvidia-modelopt=0.21.0Collection: LLM / NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information