Use explicit imports from megatronllm_deployable.py#11705
Merged
oyilmaz-nvidia merged 1 commit intomainfrom Dec 23, 2024
Merged
Use explicit imports from megatronllm_deployable.py#11705oyilmaz-nvidia merged 1 commit intomainfrom
oyilmaz-nvidia merged 1 commit intomainfrom
Conversation
…y chain Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Contributor
|
[🤖]: Hi @janekl 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
oyilmaz-nvidia
approved these changes
Dec 23, 2024
malay-nagda
pushed a commit
that referenced
this pull request
Dec 31, 2024
…y chain (#11705) Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
abhinavg4
pushed a commit
that referenced
this pull request
Jan 30, 2025
…y chain (#11705) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Abhinav Garg <abhgarg@nvidia.com>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
…y chain (NVIDIA-NeMo#11705) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Use explicit imports of from
nemo.deploy.nlp.megatronllm_deployablemodule to avoid dependency chain in case of vLLM. This module is not needed for vLLM deployments and the virtualenv/opt/venvfor vLLM should only contain minimal set of requirements to run it.Otherwise just importing from
nemo.deploy.nlptriggers many unnecessary requirements.Collection: NLP/LLM
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information