Cherry pick Configure FSDP to keep module params (12074) into r2.2.0#12524
Merged
chtruong814 merged 1 commit intor2.2.0from Mar 7, 2025
Merged
Cherry pick Configure FSDP to keep module params (12074) into r2.2.0#12524chtruong814 merged 1 commit intor2.2.0from
Configure FSDP to keep module params (12074) into r2.2.0#12524chtruong814 merged 1 commit intor2.2.0from
Conversation
Needed to avoid bug with Transformer Engine LayerNorm, which needs to access module parameters. Signed-off-by: Tim Moon <tmoon@nvidia.com>
Contributor
|
[🤖]: Hi @ko3n1g 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
chtruong814
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @timmoon10 👋,