Skip to content

Fix register artifacts #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borisfom merged 1 commit into from
May 5, 2022
Merged

Fix register artifacts #4116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions nemo/collections/nlp/models/nlp_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ def __init__(self, cfg: DictConfig, trainer: Trainer = None, no_lm_init=False):
# Required to pull up the config for MegatronBert models
self.pretrained_model_name = cfg.language_model.pretrained_model_name

# register encoder config
self.register_bert_model()

if (
cfg.tokenizer is not None
and cfg.tokenizer.get("tokenizer_name", "") is not None
Expand All @@ -133,6 +130,8 @@ def __init__(self, cfg: DictConfig, trainer: Trainer = None, no_lm_init=False):

if cfg.get('language_model') and not no_lm_init:
self.bert_model = bert_model
# register encoder config
self.register_bert_model()

def register_artifact(
self, config_path: str, src: str, verify_src_exists: bool = False,
Expand Down