Conversation
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
…to fix_speaker_utils
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Signed-off-by: Taejin Park <tango4j@gmail.com>
Collaborator
|
/blossom-ci |
nithinraok
requested changes
May 10, 2022
Member
There was a problem hiding this comment.
Can you replace this piece of code with #4125 for getting uniq name.
This avoids issues if basename has dot in it.
Collaborator
Author
There was a problem hiding this comment.
Replaced with the line Yang has changed.
Member
There was a problem hiding this comment.
same here as mentioned above for uniqname fix
Collaborator
Author
There was a problem hiding this comment.
This line is also replaced with the line Yang pushed in PR #4125.
Member
There was a problem hiding this comment.
specified file -> specified manifest file
Signed-off-by: Taejin Park <tango4j@gmail.com>
…to fix_speaker_utils
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR fixes bugs for certain cases and adds few functions. Previously, write_rttm2manifest function had following issues:
(1) Offset is not considered
(2) Occasionally, the function was returning the segments outside the given (offset, offset+duration) range.
The newly written part is compared with the original code, and confirmed to
Collection: [Note which collection this PR will affect]
ASR
Changelog
Added following functions in speaker_utils.py.
These functions are needed to extract oracle VAD stamp from manfiest file, considering the offset and duration.
In addition, these functions are designed for the future use for streaming diarization.
get_uniq_id_with_dur()
getSubRangeList()
getMinMaxOfRangeList()
getMergedRanges()
int2fl()
fl2int()
combine_int_overlaps()
combine_float_overlaps()
getOverlapRange()
isOverlap()
and modified following functions:
write_rttm2manifest() - to resolve existing issues
segments_manifest_to_subsegments_manifest() - Now, if include_uniq_id = True, the function adds uniq_id to the created subsegment manifest file. This is for using segmentation files for truncated (chopped) diarization dataset, where uniq_id is overlapped if not specified. (One audio file creates multiple 30~40sec utterances and these short utterances should be identifed too.)
Details can be found in the docstring in each function definition.
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information