Skip to content

Fix epoch end for NeMo NMT #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericharper merged 3 commits into from
May 26, 2022
Merged

Fix epoch end for NeMo NMT #4265

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85e7ee7
Fix epoch end
MaximumEntropy May 25, 2022
cf2aa8f
Merge branch 'r1.9.0' into nmt_epoch_end_fix
MaximumEntropy May 25, 2022
0352807
Merge branch 'r1.9.0' into nmt_epoch_end_fix
ericharper May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nemo/collections/nlp/models/machine_translation/mt_enc_dec_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,9 @@ def validation_step(self, batch, batch_idx, dataloader_idx=0):

def eval_epoch_end(self, outputs, mode, global_rank):
# if user specifies one validation dataloader, then PTL reverts to giving a list of dictionary instead of a list of list of dictionary
if not outputs:
return

if isinstance(outputs[0], dict):
outputs = [outputs]

Expand Down