Conversation
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
3 tasks
odelalleau
reviewed
Sep 25, 2023
| # Add lightning file logging to global_rank zero | ||
| add_filehandlers_to_pl_logger(log_dir / 'lightning_logs.txt', log_dir / 'nemo_error_log.txt') | ||
|
|
||
| elif trainer.num_devices * trainer.num_devices > 1: |
Collaborator
There was a problem hiding this comment.
Was it meant to be trainer.num_nodes * trainer.num_devices?
Collaborator
Author
There was a problem hiding this comment.
ah thanks for catching that!
Collaborator
There was a problem hiding this comment.
yeah it's not a big deal though since if it's unlikely that someone runs with num_nodes > 1 and num_devices == 1 ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Fixes #7460. Exp manager now has a sleep argument to sleep the non rank 0 ranks.
PR Type:
Additional Information
The moving of files in
exp_managermay cause crashes in other processes #7460