bugfix: pin nemo-text-process to fix Chinese normalizer error.#7627
Merged
bugfix: pin nemo-text-process to fix Chinese normalizer error.#7627
Conversation
76d230e to
9131c9f
Compare
f2f3458 to
9d6f9ae
Compare
…er error. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
9d6f9ae to
30b6748
Compare
ekmb
reviewed
Oct 10, 2023
blisc
reviewed
Oct 10, 2023
…normalizer error." This reverts commit 30b6748.
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
8 tasks
blisc
approved these changes
Oct 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* bugfix: safeguard nemo-text-process==0.1.8rc0 to fix Chinese normalizer error. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> * Revert "bugfix: safeguard nemo-text-process==0.1.8rc0 to fix Chinese normalizer error." This reverts commit 30b6748. * revert previous solution and pin version. Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com> --------- Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Related to bug report,
Chinese normalizer outputted wrong normalized text for the input, '双辽境内除东辽河、西辽河等5条河流', where we expect '双辽境内除东辽河、西辽河等五条河流'.
Evidence
On the latest version, i.e. nemo-text-processing=0.2.0rc0, it always normalized it as '双辽境内除东辽河、西辽河等5条河流';
On the previous version, i.e. nemo-text-processing=0.1.8rc0, it normalized it as expected text, '双辽境内除东辽河、西辽河等五条河流'.
Detailed Log
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information