Skip to content

Fix CPU initialization of GPT models #7889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuichenx merged 2 commits into from
Nov 21, 2023
Merged

Fix CPU initialization of GPT models #7889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa43a2
add cpu init check
cuichenx Nov 15, 2023
5ce6492
Merge branch 'main' into chcui/fix_gpt_cpu_init
cuichenx Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def __init__(self, cfg: DictConfig, trainer: Trainer):

if self.megatron_amp_O2:

if not self.with_distributed_adam:
if not self.with_distributed_adam and not self.cfg.get("use_cpu_initialization", False):
# Pre-allocate the model on GPU to have master parameters allocated on the same device with matching data type
if isinstance(self.model, list):
for module in self.model:
Expand Down