Merged
Conversation
26d223e to
9bf1f53
Compare
8 tasks
9bf1f53 to
23019ea
Compare
Collaborator
Author
23019ea to
3dbbe05
Compare
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
3dbbe05 to
0dffbc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Currently Megatron-LM creates causal attention mask for a local-layer spec model on its own -- see NVIDIA/Megatron-LM@a45805a -- and hence
attention_mask=Nonecan be specified in Nemo. In this MR, I'm using this new M-LM functionality when creatingfwd_output_only_funcfunction.Broader functional tests for
fwd_output_only_funcwill follow in subsequent MRs.Collection: NLP
Jenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information