Skip to content

Create causal mask on MCore/TE side#8281

Merged
janekl merged 1 commit intomainfrom
jlasek/causal_mask_mcore_model
Mar 1, 2024
Merged

Create causal mask on MCore/TE side#8281
janekl merged 1 commit intomainfrom
jlasek/causal_mask_mcore_model

Conversation

@janekl
Copy link
Collaborator

@janekl janekl commented Jan 31, 2024

What does this PR do ?

Currently Megatron-LM creates causal attention mask for a local-layer spec model on its own -- see NVIDIA/Megatron-LM@a45805a -- and hence attention_mask=None can be specified in Nemo. In this MR, I'm using this new M-LM functionality when creating fwd_output_only_func function.

Broader functional tests for fwd_output_only_func will follow in subsequent MRs.

Collection: NLP

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@janekl janekl force-pushed the jlasek/causal_mask_mcore_model branch 2 times, most recently from 26d223e to 9bf1f53 Compare February 13, 2024 08:47
@janekl janekl force-pushed the jlasek/causal_mask_mcore_model branch from 9bf1f53 to 23019ea Compare February 19, 2024 13:53
@github-actions github-actions bot removed the CI label Feb 19, 2024
@janekl janekl requested a review from titu1994 February 21, 2024 19:24
@janekl
Copy link
Collaborator Author

janekl commented Feb 21, 2024

@titu1994 could you help to land it? Prerequisite is mcore=0.5.0 #8465

@janekl janekl force-pushed the jlasek/causal_mask_mcore_model branch from 23019ea to 3dbbe05 Compare February 23, 2024 08:19
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl force-pushed the jlasek/causal_mask_mcore_model branch from 3dbbe05 to 0dffbc6 Compare March 1, 2024 08:53
@janekl janekl requested review from dimapihtar and gshennvm March 1, 2024 11:49
Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@janekl janekl merged commit eed7cbd into main Mar 1, 2024
@janekl janekl deleted the jlasek/causal_mask_mcore_model branch March 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants