Fix memory leak caused by context parallelism hanging references by omegaconf#8319
Merged
ericharper merged 1 commit intomainfrom Feb 5, 2024
Merged
Conversation
…megaconf (#8299) * save cp_size to self Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * use parallel_state instead of self Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com>
Collaborator
|
jenkins |
Contributor
|
LGTM! |
ericharper
deleted the
cherry-pick-main-e9320eda5a1ffa18e230bbe7ea03d4cf6d7374de
branch
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…megaconf (NVIDIA-NeMo#8299) (NVIDIA-NeMo#8319) * save cp_size to self * use parallel_state instead of self --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
layalir
pushed a commit
to layalir/NeMo
that referenced
this pull request
Feb 29, 2024
…megaconf (NVIDIA-NeMo#8299) (NVIDIA-NeMo#8319) * save cp_size to self * use parallel_state instead of self --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com>
layalir
pushed a commit
to layalir/NeMo
that referenced
this pull request
Mar 1, 2024
…megaconf (NVIDIA-NeMo#8299) (NVIDIA-NeMo#8319) * save cp_size to self * use parallel_state instead of self --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
…megaconf (#8299) (#8319) * save cp_size to self * use parallel_state instead of self --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…megaconf (NVIDIA-NeMo#8299) (NVIDIA-NeMo#8319) * save cp_size to self * use parallel_state instead of self --------- Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information