Skip to content

distributed fused adam + rampup bs support #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericharper merged 1 commit into from
Feb 16, 2024
Merged

distributed fused adam + rampup bs support #8321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,11 +1305,6 @@ def setup(self, stage=None):
self.init_global_step = self.trainer.global_step

if self.rampup_batch_size:
optimizer = self.cfg.optim.get('name', None)
assert (
optimizer == 'fused_adam'
), f'{optimizer} optimizer is not supported yet with rampup batch size. Please, use fused_adam optimizer instead.'

num_microbatch_calculator = apex.transformer.pipeline_parallel.utils._GLOBAL_NUM_MICROBATCHES_CALCULATOR
num_microbatch_calculator.update(self.init_consumed_samples, consistency_check=False)
self.prev_consumed_samples = self.init_consumed_samples
Expand Down