Skip to content

Huvu/mcore t5#9677

Merged
pablo-garay merged 28 commits intomainfrom
huvu/mcore_t5
Jul 11, 2024
Merged

Huvu/mcore t5#9677
pablo-garay merged 28 commits intomainfrom
huvu/mcore_t5

Conversation

@huvunvidia
Copy link
Collaborator

@huvunvidia huvunvidia commented Jul 10, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Huy Vu2 added 25 commits June 10, 2024 14:14
huvu/mcore_t5 first commit from local
08bd267
removing DEBUGGING prints
e34dcb1
cleaning megatron_lm_encoder_decoder_model.py code
800ad1e
Merge remote-tracking branch 'origin/main' into huvu/mcore_t5
bf54880
cleaning code
22cc5a5
Merge remote-tracking branch 'origin/main' into huvu/mcore_t5
20b5c63
adding Github action test
798bb96
Merge remote-tracking branch 'origin/main' into huvu/mcore_t5
45ff029
only run mcore T5 test
a346548
only run mcore T5 test
cfcb5a7
only run mcore T5 test
b8a20af
only run mcore T5 test
74264f5
reset .github/workflows/cicd-main.yml
ee03211
reset .github/workflows/cicd-main.yml
b665781
adding condition self.mcore_t5 when running self.build_transformer_co…
2805e32 
…nfig()
refractor megatron_lm_encoder_decoder_model.py to not use self.model
d4379f6
only run T5-related tests
54537d0
remove all self.model
fe165fc
reset cicd file
6168a44
reset cicd file
22262aa
updating codes remove duplicate if/else; adding mcore/transformer_eng…
1325a9b 
…ine to config file
Merge remote-tracking branch 'origin/main' into huvu/mcore_t5
5125ce9
adjust +model.mcore_t5=True
1afcf3c
Merge remote-tracking branch 'origin/main' into huvu/mcore_t5
8ae427e
fix training for non-mcore, bf16, O2
2f2bab1
@pablo-garay pablo-garay merged commit d4f1d3c into main Jul 11, 2024
@pablo-garay pablo-garay deleted the huvu/mcore_t5 branch July 11, 2024 16:15
maanug-nv pushed a commit that referenced this pull request Jul 14, 2024
@huvunvidia @maanug-nv
Huvu/mcore t5 (#9677)
b5cb547 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
nikitaved pushed a commit to nikitaved/NeMo that referenced this pull request Jul 16, 2024
@huvunvidia @nikitaved
Huvu/mcore t5 (NVIDIA-NeMo#9677)
3d8ae84 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
huvunvidia pushed a commit that referenced this pull request Jul 16, 2024
restore cicd tests from PR #9677 deletion
9dbdaba
@huvunvidia huvunvidia mentioned this pull request Jul 16, 2024
Closed
8 tasks
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
@huvunvidia @ertkonuk
Huvu/mcore t5 (#9677)
45333e8 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
malay-nagda pushed a commit to malay-nagda/NeMo that referenced this pull request Jul 26, 2024
@huvunvidia
Huvu/mcore t5 (NVIDIA-NeMo#9677)
0b8cf40 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Malay Nagda <malayn@malayn-mlt.client.nvidia.com>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Aug 6, 2024
@huvunvidia @tonyjie
Huvu/mcore t5 (NVIDIA-NeMo#9677)
23beee3 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: tonyjie <jl4257@cornell.edu>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@huvunvidia @monica-sekoyan
Huvu/mcore t5 (#9677)
7899c14 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@huvunvidia
Huvu/mcore t5 (NVIDIA-NeMo#9677)
545c936 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
@huvunvidia @XuesongYang
Huvu/mcore t5 (NVIDIA-NeMo#9677)
b6f63a0 
* huvu/mcore_t5 first commit from local

* removing DEBUGGING prints

* cleaning megatron_lm_encoder_decoder_model.py code

* cleaning code

* adding Github action test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* only run mcore T5 test

* reset .github/workflows/cicd-main.yml

* reset .github/workflows/cicd-main.yml

* adding condition self.mcore_t5 when running self.build_transformer_config()

* refractor megatron_lm_encoder_decoder_model.py to not use self.model

* only run T5-related tests

* remove all self.model

* reset cicd file

* reset cicd file

* updating codes remove duplicate if/else; adding mcore/transformer_engine to config file

* adjust +model.mcore_t5=True

* fix training for non-mcore, bf16, O2

* reset cicd-main.yml

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pablo-garay pablo-garay pablo-garay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI NLP Run CICD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huvunvidia @pablo-garay